Justin Starry

Results 115 comments of Justin Starry

Blocked on activation of this feature: https://github.com/solana-labs/solana/issues/33888

I agree that this code is messy but I'm not sure that this is the right way to clean it up. I believe the reason that the `lamports_per_signature` is passed...

Sounds great! Though I think we could expand on the existing `inner_instructions` field in RPC responses rather than replace it with a new field. I'm in favor of deprecating `return_data`...

https://github.com/solana-labs/solana/pull/28430 adds the `stack_height` for inner instructions. It would still be nice to record return data and compute units used for each instruction

Totally agree that the docs need to be much clearer. I think this might be more of an examples issue than a docs issue --- Edited to remove incorrect statement...

No it's definitely a docs issue, it doesn't say where the `main.js` comes from See here: https://github.com/yewstack/yew-wasm-pack-minimal/blob/master/main.js

Honestly, it's hard to answer that. I'm not a big fan of the `wasm-pack` experience. It works well enough with webpack.. but on its own, not great. It would be...

Best is too subjective IMO. My personal app uses `webpack` + `wasm-pack` but that's just because I'm really familiar with `webpack`. I don't think Yew needs to give a strong...

@hituzi-no-sippo yes, good catch. It should be `batch_callback` 👍