collectd-write_graphite icon indicating copy to clipboard operation
collectd-write_graphite copied to clipboard

Published 20 hours ago • verified publisher icon jssjr

Fixed two bugs that were wrecking my collectd servers, notes included in each commit.

Open dnf opened this issue 13 years ago • 1 comments

dnf avatar Mar 09 '12 02:03 dnf

FYI, the first issue is also fixed by collectd/collectd@acd2fa45d20e4445140fbad3dae7032019dff16b.

The second issue is avoided in the upstream sources by allowing the user to specify whether to always add the data source name or do this only when the data set has multiple data sources. This was changed in a couple of commits, the most relevant one is collectd/collectd@184f1db5791939c13d7e65bb1d05dd2ff0f9ae6d.

I'd fix the second issue by not passing NULL in https://github.com/jssjr/collectd-write_graphite/blob/master/src/write_graphite.c#L563 but rather ds->ds[0].name.

Best regards, —octo

octo avatar Mar 09 '12 12:03 octo