jsr icon indicating copy to clipboard operation
jsr copied to clipboard

feat: include module paths in Dependencies

Open jollytoad opened this issue 1 year ago • 4 comments

Closes #310

I feel the Dependencies tab is currently quite misleading, and doesn't reflect that only certain modules from a package are actually depended upon.

This PR adds the individual modules paths with links to the whole package and to the individual module docs (for npm the module path is not linked as there is nowhere really for it to link to).

Screenshot 2024-05-23 at 12 13 42 pm

jollytoad avatar May 23 '24 11:05 jollytoad

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar May 23 '24 11:05 CLAassistant

Hey, sorry for the late review.

I don't like the idea that the same package will show up in multiple rows. Can you change this code so that we still only have one row per package + version constraint, but then have a smaller text below the package name that has the list of imported "exports"?

lucacasonato avatar Jun 07 '24 14:06 lucacasonato

Hey, no problem, glad you had chance to review.

So yeah, I agree, and I was wondering about this. I'd considered grouping paths like versions are, although if one import is for one version and another for a different version then the list of what is import from what version becomes misleading. But I expect that to be quite an unusual situation anyway.

Happy to do some tweaking now I know you are happy with the general idea of showing this additional information.

jollytoad avatar Jun 07 '24 15:06 jollytoad

I tried a few variations, including making the repeated package invisible but retaining the separate rows, and listing the modules under the package name, but these looked odd and confusing. IMHO, this was the best result I came up with:

Screenshot 2024-06-10 at 10 35 54 AM

If a package depends only on the default module then the modules column will be empty, but if it depends on default and other paths then (default) is shown at the top of the modules list. Although I need to find a package that actually does that.

jollytoad avatar Jun 10 '24 09:06 jollytoad

Any thoughts on progressing this?

jollytoad avatar Nov 18 '24 17:11 jollytoad

@jollytoad apologies for the delays on this. I am in favour of this and i like the design (though maybe the version column should be the last one?), though i will pass this through an aditional person in regards of design

crowlKats avatar Nov 19 '24 01:11 crowlKats

I like it. 👍

josh-collinsworth avatar Nov 19 '24 16:11 josh-collinsworth