jspsych
Change broken selection in enable_button_after parameter
The button class was not being selected correctly resulting in a broken enable_button_after parameter
🦋 Changeset detected
Latest commit: dd3caab64f2f68ffcb97ec59993c5daa645e818b
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 1 package
| Name | Type |
|---|---|
| @jspsych/plugin-html-button-response | Patch |
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
![changeset-bot[bot] avatar](https://avatars.githubusercontent.com/in/28616?v=4 "Published by a pub.dev verified publisher"){kind=small}
@jadeddelta is this an issue in any of the other button plugins?
(might be worth adding a test case to verify that disabling is happening as expected)
looks like it's not an issue in other plugins, and in fact this specific plugin does have a disabled button test, it was just skipping it because the array that querySelectorAll generated was always empty, meaning it would never reach the expect statements. went ahead and added a check for it, should all be good now!
