jsPsych icon indicating copy to clipboard operation
jsPsych copied to clipboard

fix for wrong audio mimetype preventing playback in Safari

Open bbonf opened this issue 1 year ago • 1 comments

Hello,

While preparing an experiment using the html audio response plugin, I found out that playback of recorded audio (using {allow_playback: true}) doesn't work in Safari (tested on 16.3). This happens because the audio mimetype is hardcoded as "audio/webm" while Safari is using mp4. From what I've seen, Chrome is indeed recording webm, and Firefox seems to work regardless of this mismatch.

Anyway, the fix here would be to just use whatever is provided in recorded_data_chunks.

Thanks!

bbonf avatar Mar 24 '23 10:03 bbonf

⚠️ No Changeset found

Latest commit: cc1ca257f5832a3d73ccae6bc700e9a9fe7ca695

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Mar 24 '23 10:03 changeset-bot[bot]