jsperf.com must be reloaded after authing with github

[ianwremmel]

I reported #479 thinking it was an adblocker problem, but it actually turns out to be how the auth flow works. Whether I'm previously logged into GitHub or not, it seems a reload is necessary in order to get the authenticated UI to appear. I suspected adblockers earlier because turning them off triggers a page reload, thus obscuring the real culprit.

Scenario: I am logged into GitHub.com but not jsperf.com

When I click the "Login with GitHub to create test cases" button, the page flickers and I'm shown the unauthenticated UI. When I reload, I see the create test case UI.

Scenario: I am not logged into GitHub.com or jsperf.com

When I click the "Login with GitHub to create test cases" button, I'm redirected to GitHub to login. After logging in, I'm returned to jsperf.com and I see the unauthenticated UI. When I reload, I see the create test case UI.

[asilluron]

OS? Browser? Etc

I'm unable to duplicate this in any browser of mine

[ianwremmel]

I was just able to reproduce on macOS 10.14.1 in Firefox 64 with all addons disabled and Chrome 71 (with extensions enabled).

[soulofmischief]

I ran into this bug and spent a good five or six minutes just smashing the login button trying to figure out what was going on. Firefox 68 on Fedora.