Julian Sparber

For now all Captive portals with 1 static page and 1 form on it should work. So that means when the web page is generated by Javascript, or if it...

For now i don't know how to test different APs. I will look into it as soon as I have time.

Does the normal captive portal app work?

After restating tangram the pages are still there but don't have any webpage set and also other settable fields are empty.

@swick thanks for the review :)

> LGTM. Even though portals are versioned and this isn't really required, this makes it much nicer for apps to use. > > e: I'll redact this. The notifications test...

> Probably just some environment variable to override the icon_validator executable path that you set in test-portals.c and the python test framework. Not sure if that's so easy, we don't...

> If the env var is only for testing then we probably want the names to be consistent (`XDG_DESKTOP_PORTAL_TEST_VALIDATE_ICON` or something like that). I think the env var can be...

the icon validator doesn't work, but the CI logs don't show any reason. Locally it works just fine. It could have to do something with the sandbox.

> It's running into a timeout (`TIMEOUT 30.01s killed by signal 15 SIGTERM`) which suggests that it's either actually taking a really long time or your new test is getting...