GroceryList icon indicating copy to clipboard operation
GroceryList copied to clipboard

Add offline fetch of repository error to view model errors signal

Open stevemoser opened this issue 10 years ago • 3 comments

Not sure if this is the right way to fix the offline error but it fixes #16 for me. Also it seems the the error alert view eventually appears but not instantly, probably because [alert show] isn't on the main thread. :beers:

stevemoser avatar Feb 16 '14 18:02 stevemoser

Thanks! Just a couple notes.

jspahrsummers avatar Feb 17 '14 16:02 jspahrsummers

Np. I think I fixed the white space, let me know otherwise. Not sure as I never use tabs with Xcode.

stevemoser avatar Feb 19 '14 01:02 stevemoser

Yep, the indentation is certainly fixed, but there was a note about the threading too (regarding self->_errors sendNext:):

This should only happen on the main thread. You can use [RACScheduler.mainThreadScheduler schedule:] to do that.

jspahrsummers avatar Feb 19 '14 18:02 jspahrsummers