Josh Soref comments

Results 1027 comments of


                                            Josh Soref

Go: zip-slip FP / missed a zip-slip guard in argoproj/argo-cd

In the interim, can the qhelp at least be improved to at least draw people's attention to these deficiencies? https://github.com/github/codeql/blob/590e93d8edec4d7216935ed4425a7ab77b3b2f34/go/ql/src/Security/CWE-022/ZipSlip.qhelp#L33-L41 I understand that improved algorithms take time, but if I...

Apply change proposed in issue 899

/approve

Apply change proposed in issue 899

/lgtm

CleartextLogging.qhelp needs more help

Maybe the advice should be: > If this is intentional, use `fmt.Stringer.String` with an example of how to use it. (I can't tell if that works, but https://github.com/github/codeql/commit/7b903dd0625c53172357b55cdaf3c352cfe7cd2d seems to...

Documentation has mismatch between Encoded Certificate and Human Readable presentation

I originally noted this problem in https://github.com/traefik/traefik/pull/6471#issuecomment-2327023039

WIP: Reduce load on the Kubernetes API server by enabling the WatchList (Streaming Lists) feature

/kind bug

feat(helm): add .global.imageRegistry

/kind feature

Route53: Allow STS token to be refreshed by the AWS client if necessary

/kind bug feature

changed the scorecard badge link to the standard format

/kind cleanup

Confusing error when trying to deploy Rust docs

re:, https://github.com/actions/deploy-pages/issues/303#issuecomment-1915616098, @yoannchaudet: if I made a PR to add a mention about ensuring that all files/directories are world readable, would it be accepted? (It doesn't make sense to link...