Josh Soref
Josh Soref
I'm not a maintainer, but this project has tests... https://github.com/Netflix/Hystrix/tree/master/hystrix-core/src/test I'd expect anything that's changing its behavior to be accompanied by either a change to an existing test or the...
@azillion: Could your bot please detect when the go versions are below the threshold required and suggest bumping them as well?
I have.
That's a good point, I should have a good showcase. Here's a simple example: In microsoft/terminal#5485, [github-actions commented](https://github.com/microsoft/terminal/pull/5485#commitcomment-38684451) and left [annotations](https://github.com/microsoft/terminal/commit/f343e2476c5308df4fa4eba89d8969285c149ec6#diff-e8986dd365aa23a5fbc39a8f26e76d58R39). Fwiw, the doubled annotation in line 40 is because...
I've been thinking about it. I definitely intend to improve that part of the flow. Probably sooner rather than later as it's one of the things people have been asking...
Cross filed as: https://github.com/orgs/community/discussions/49245#discussioncomment-5209064 https://support.github.com/ticket/personal/0/2042233 https://github.com/github/docs/issues/25336#issuecomment-1736251764
No, your action will still run, you just won't easily know where your action came from and what version you are. If you burn that info into your repo w/...
Yes, I sympathize -- that's why I filed this. Fwiw, there is a workaround noted in https://github.com/github/docs/issues/25336#issuecomment-1736251764 (I think @ChristopherHX might have suggested it somewhere), and it looks like they're...
Right, which means this is how I worked around it: https://github.com/check-spelling/check-spelling/blob/ed14e107b2404ceec4db32161bc3cc353b123b46/.github/workflows/spelling.yml#L114 https://github.com/check-spelling/check-spelling/blob/ed14e107b2404ceec4db32161bc3cc353b123b46/action.yml#L522-L523 It's good enough for testing...
@sbaogang: anything I could do to help move this along?