Josh Soref

Results 1027 comments of Josh Soref

So, here's a reworked version: > #### [🏠 Summary](https://github.com/check-spelling-sandbox/check-spelling-actions-runs-links/actions/runs/8541247470) > ##### Annotations > 1 notice > ℹ️ [Workflow skipped](https://github.com/check-spelling-sandbox/check-spelling-actions-runs-links/actions/runs/8541247470/job/23401477856#step:2:374) See `check-spelling` `pull_request_target` workflow (`.github/workflows/spelling.yml`) in PR #1. https://github.com/check-spelling-sandbox/check-spelling-actions-runs-links/actions/workflows/.github/workflows/spelling.yml?query=event:pull_request_target+branch:jsoref-patch-1 https://github.com/check-spelling-sandbox/check-spelling-actions-runs-links/pull/1/checks >...

@GeorgeXCV you're cropping the view which isn't helping, and you haven't provided a repository (which also doesn't help). My _guess_ is that this is a private repository because I can't...

@GeorgeXCV: thanks, I think I've figured out what's going on... your workflow has `suppress_push_for_open_pull_request` but it's missing `on: pull_request(_target)` -- can you please provide the workflow file from the run?...

Yeah... I think I fixed it in prerelease this morning: https://github.com/check-spelling/check-spelling/commit/29a57c171b415fdd05fc34d8bd17f39ad2620598

Yeah, I need to make sure that nothing breaks. The actions/upload-artifact & actions/download-artifact change that GitHub made was a messy breaking change and it requires some actual testing of a...

The deprecation shouldn't actually do anything per https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/ Here's a run of check-spelling v0.0.22 using node20 instead of node16: https://github.com/check-spelling-sandbox/web-qa/actions/runs/8635992495 -- things seem to work fine. --- I've done some...

Fair. I've been thinking about renaming all of my settings. I've been using `_`s because they're easier to reason with in shell, but actions prefer `-`s. It'll be a slight...

The documentation doesn't really explain enough of these things, so I'm not entirely certain if the statement is technically right or wrong: https://docs.github.com/en/actions/creating-actions/metadata-syntax-for-github-actions#inputsinput_idrequired https://docs.github.com/en/actions/creating-actions/metadata-syntax-for-github-actions#inputsinput_iddefault I suppose I could file a...

Fwiw, I've started working on these things. I expect to include changes in prerelease shortly.

I ran into a bunch of snags trying to redo all of my inputs and punted on this work, so it is not include in v0.0.22. I do intend to...