Josh Soref

Results 1027 comments of Josh Soref

The code does: https://github.com/cert-manager/cert-manager/blob/7689ea69184e32652d18bec788f89230be503eab/pkg/controller/certificaterequests/approver/approver.go#L102

The general advice is here: https://docs.github.com/en/actions/reference/security/secure-use#use-an-intermediate-environment-variable > [Use an intermediate environment variable](https://docs.github.com/en/actions/reference/security/secure-use#use-an-intermediate-environment-variable) For inline scripts, the preferred approach to handling untrusted input is to set the value of the expression...

I see a couple of things are unhappy.... I'm not sure where the test is getting its preferred value from, I'd be inclined to drop it: ```diff @@ - eval_dev_images

Note that I'm on vacation and doing this in free time. I'll check in later to get some of the tests happy (they refused to run on forks, about which...

Split: - [ ] #5490 - [ ] #5491 - [ ] #5492 - [ ] #5493 - [ ] #5494 - [ ] #5495

I wonder if https://mesonbuild.com/Creating-releases.html should include a note about [meson.add_dist_script()](https://mesonbuild.com/Reference-manual_builtin_meson.html#mesonadd_dist_script).