lity icon indicating copy to clipboard operation
lity copied to clipboard

Lity stopped working for YouTube videos

Open dmitry1704 opened this issue 4 years ago • 5 comments

Hi,

For some reason, Lity has stopped working with YouTube videos. Ex: https://rsaa.anu.edu.au/public/movies-public-lectures

We have experienced this issue across different university sites. Not sure if the issue is related to some update by YouTube.

Thank you, Dima

dmitry1704 avatar Jun 08 '20 22:06 dmitry1704

This seems to be related to jQuery update done on Drupal 7.70. I haven't found a solution yet.

wakkoism avatar Jun 11 '20 21:06 wakkoism

@dmitry1704 , I figured out the issue, I've created a patch to fix this PR - https://github.com/jsor/lity/pull/246/files Basically there the new update on Drupal runs through htmlprefilter which then is passed into jQuery.clean, and gets removed because there is no self closing iframe tag.

wakkoism avatar Jun 11 '20 22:06 wakkoism

Wow @wakkoism , thank you so much for finding the issue in Drupal and sharing the patch. I'm testing it and it works.

dmitry1704 avatar Jun 16 '20 01:06 dmitry1704

@wakkoism , thank you! We've also had this problem in a Drupal 7.72 installation and closing the

pdomingos avatar Jun 29 '20 16:06 pdomingos

this patch for us as well. Any chance it will be added to a newer release?

stanbellcom avatar Nov 18 '21 14:11 stanbellcom