doctrine-postgis #62 Switch to platform options from deprecated custom schema options

#62 Switch to platform options from deprecated custom schema options

Open sasa-b opened this issue 1 year ago • 4 comments

As suspected the issue in #62 was due to using the deprecated customSchemaOptions property.

Btw this package works with PostgreSQL 15 as well, I've just noticed I've been using it with that version all this time without any issues so far, although the highest officially supported version was 13.

Aug 12 '23 10:08 sasa-b

Hi @sasa-b

I'm seeing the same issue trying to upgrade to doctrine/orm 2.16.2. We get the error you mention in #62 while running symfony console doctrine:schema:validate after updating deps.

I installed this branch locally like so:

Edit composer.json:

{
    "repositories": [
        {
            "type": "git",
            "url": "https://github.com/sasa-b/doctrine-postgis"
        }
    ],
    "require": {
        "jsor/doctrine-postgis": "dev-migration-diff-fix"
    }
}

Then run symfony composer update to install and sync lock file.

I can confirm the error goes away and locally everything looks fine.

I looked at the code and I can only say "LGTM".

What can we do to move this forward? @jsor Would you be available for review?

Sep 14 '23 14:09 florimondmanca

It seems the issue appears starting doctrine/orm 2.15.5

In this version, doctrine/orm started using platformOptions instead of customSchemaOptions

https://github.com/doctrine/orm/releases/tag/2.15.5

https://github.com/doctrine/orm/pull/10855

We're pinning to < 2.15.5 for now, waiting for this PR to land

Sep 14 '23 14:09 florimondmanca

I have the same issue here. Is any help needed to get this merged?

Sep 15 '23 11:09 TomAdam

@jsor would really appreciate if we could push this forward. It's somewhat of a blocker preventing us to move forward with new doctrine/orm versions. Many thanks for your time.