jsonresume.org icon indicating copy to clipboard operation
jsonresume.org copied to clipboard
verified publisher icon jsonresume

open source -> open-source

Open akirataguchi115 opened this issue 9 months ago • 3 comments

"open source" is a lexicalized compound noun. "open-source" is a compound modifier which is what was probably meant here.

https://opensource.org/blog/is-open-source-ever-hyphenated

Summary by CodeRabbit

  • Documentation
    • Updated text across the platform to consistently use the hyphenated "open‑source," enhancing clarity and grammatical accuracy in the initiative's description.

akirataguchi115 avatar Mar 27 '25 12:03 akirataguchi115

⚠️ No Changeset found

Latest commit: e277aeca816d42e3760941559a1015362092064f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Mar 27 '25 12:03 changeset-bot[bot]

@akirataguchi115 is attempting to deploy a commit to the JSON Resume Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Mar 27 '25 12:03 vercel[bot]

Walkthrough

The pull request updates text descriptions across several files to ensure consistent hyphenation. The phrase "open source" is changed to "open‑source" in the JSON Resume initiative descriptions found in documentation and code pages, as well as in a sample resume object's summary field. No functional, logical, or control flow changes were made.

Changes

Files Change Summary
README.md, apps/homepage2/…/page.js, apps/homepage2/…/schema/page.js, apps/registry/app/page.js Updated descriptions for the JSON Resume initiative by replacing "open source" with "open‑source".
apps/registry/…/resume.js Modified the resume object's summary field, changing "open source initiative" to "open‑source initiative".

Poem

I'm a rabbit on a merry code hop,
Hopping through files with a clever little swap.
I fixed a hyphen in text so bright,
"Open‑source" now shines in the light.
With a twitch of my nose and a joyful skip,
I celebrate clean text with a carrot tip!

[!WARNING] There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it’s a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

apps/homepage2/app/page.js

Oops! Something went wrong! :(

ESLint: 8.57.1

Error: ESLint configuration in apps/homepage2/.eslintrc.js » @repo/eslint-config-custom » eslint-config-turbo is invalid:

  • Unexpected top-level property "default".

Referenced from: /packages/eslint-config-custom/index.js at ConfigValidator.validateConfigSchema (/node_modules/.pnpm/@[email protected]/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:2177:19) at ConfigArrayFactory._normalizeConfigData (/node_modules/.pnpm/@[email protected]/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:3019:19) at ConfigArrayFactory._loadConfigData (/node_modules/.pnpm/@[email protected]/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:2984:21) at ConfigArrayFactory._loadExtendedShareableConfig (/node_modules/.pnpm/@[email protected]/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:3285:21) at ConfigArrayFactory._loadExtends (/node_modules/.pnpm/@[email protected]/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:3156:25) at ConfigArrayFactory._normalizeObjectConfigDataBody (/node_modules/.pnpm/@[email protected]/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:3095:25) at _normalizeObjectConfigDataBody.next () at ConfigArrayFactory._normalizeObjectConfigData (/node_modules/.pnpm/@[email protected]/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:3040:20) at _normalizeObjectConfigData.next () at ConfigArrayFactory._normalizeObjectConfigDataBody (/node_modules/.pnpm/@[email protected]/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:3095:25)

apps/homepage2/app/schema/page.js

Oops! Something went wrong! :(

ESLint: 8.57.1

Error: ESLint configuration in apps/homepage2/.eslintrc.js » @repo/eslint-config-custom » eslint-config-turbo is invalid:

  • Unexpected top-level property "default".

Referenced from: /packages/eslint-config-custom/index.js at ConfigValidator.validateConfigSchema (/node_modules/.pnpm/@[email protected]/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:2177:19) at ConfigArrayFactory._normalizeConfigData (/node_modules/.pnpm/@[email protected]/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:3019:19) at ConfigArrayFactory._loadConfigData (/node_modules/.pnpm/@[email protected]/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:2984:21) at ConfigArrayFactory._loadExtendedShareableConfig (/node_modules/.pnpm/@[email protected]/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:3285:21) at ConfigArrayFactory._loadExtends (/node_modules/.pnpm/@[email protected]/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:3156:25) at ConfigArrayFactory._normalizeObjectConfigDataBody (/node_modules/.pnpm/@[email protected]/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:3095:25) at _normalizeObjectConfigDataBody.next () at ConfigArrayFactory._normalizeObjectConfigData (/node_modules/.pnpm/@[email protected]/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:3040:20) at _normalizeObjectConfigData.next () at ConfigArrayFactory._normalizeObjectConfigDataBody (/node_modules/.pnpm/@[email protected]/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:3095:25)

apps/registry/app/page.js

Oops! Something went wrong! :(

ESLint: 8.57.1

Error: ESLint configuration in apps/registry/.eslintrc.js » @repo/eslint-config-custom » eslint-config-turbo is invalid:

  • Unexpected top-level property "default".

Referenced from: /packages/eslint-config-custom/index.js at ConfigValidator.validateConfigSchema (/node_modules/.pnpm/@[email protected]/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:2177:19) at ConfigArrayFactory._normalizeConfigData (/node_modules/.pnpm/@[email protected]/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:3019:19) at ConfigArrayFactory._loadConfigData (/node_modules/.pnpm/@[email protected]/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:2984:21) at ConfigArrayFactory._loadExtendedShareableConfig (/node_modules/.pnpm/@[email protected]/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:3285:21) at ConfigArrayFactory._loadExtends (/node_modules/.pnpm/@[email protected]/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:3156:25) at ConfigArrayFactory._normalizeObjectConfigDataBody (/node_modules/.pnpm/@[email protected]/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:3095:25) at _normalizeObjectConfigDataBody.next () at ConfigArrayFactory._normalizeObjectConfigData (/node_modules/.pnpm/@[email protected]/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:3040:20) at _normalizeObjectConfigData.next () at ConfigArrayFactory._normalizeObjectConfigDataBody (/node_modules/.pnpm/@[email protected]/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:3095:25)

  • 1 others
✨ Finishing Touches
  • [ ] 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Mar 27 '25 12:03 coderabbitai[bot]

✅ Merged manually with attribution

Thank you for the grammar fix! You're absolutely correct that "open-source" should be hyphenated when used as a compound modifier.

I've applied your changes in commit b5e4ba4 with proper co-author attribution. The PR was manually merged due to base branch divergence, but all your suggested changes have been incorporated:

  • ✅ README.md
  • ✅ apps/homepage2/app/page.js
  • ✅ apps/homepage2/app/schema/page.js

The other files in your PR appear to have already been updated or refactored.

Commit: b5e4ba4

Thank you for contributing to JSON Resume! 🎉

thomasdavis avatar Oct 05 '25 02:10 thomasdavis