jsonresume-theme-boilerplate icon indicating copy to clipboard operation
jsonresume-theme-boilerplate copied to clipboard

Close div tag in resume.hbs

Open ciderpunx opened this issue 8 years ago • 7 comments

Fixes: #15

ciderpunx avatar Jan 07 '17 17:01 ciderpunx

You should convert your indentation from tabs to spaces.

ishu3101 avatar Jan 21 '17 04:01 ishu3101

@Ishu3101 - the rest of the code uses tabs, so I thought it better to be consistent.

ciderpunx avatar Jan 21 '17 13:01 ciderpunx

I see that in the commit that you have made above, the git diff is showing extra tabs have been added before each line (as shown in the screenshot below) which means the alignment of the code is not write and what git diff is telling is that you have made changes to line 16 - 27 instead of just adding the closing div tag.

image

ishu3101 avatar Jan 21 '17 23:01 ishu3101

Ah right, got you. I've de-indented so the indentation follows the original way of doing it.

close_div_tag_in_resume_hbs_by_ciderpunx_pull_request_16_jsonresume_jsonresume-theme-boilerplate_-_2017-01-23_15_09_11

ciderpunx avatar Jan 23 '17 15:01 ciderpunx

I noticed that you have also removed the indentation of the closing body tag as well.

ishu3101 avatar Jan 23 '17 22:01 ishu3101

Re-added, also added back the empty line directly after the opening body tag.

ciderpunx avatar Jan 24 '17 10:01 ciderpunx

Great. You should squash your commits into a single commit as it makes no sense to pollute the history with 3 commits of you just fixing things. A single commit of everything correct is the correct way to go.

ishu3101 avatar Jan 25 '17 04:01 ishu3101