json-schema icon indicating copy to clipboard operation
json-schema copied to clipboard

Published 20 hours ago • verified publisher icon jsonrainbow

Invalid string validation

Open snapshotpl opened this issue 1 year ago • 2 comments

Test case for invalid string type validation. I cannot run this test case locally because missing php 8 support for test

snapshotpl avatar Nov 28 '23 15:11 snapshotpl

@snapshotpl thanks for the effort. Sadly the PR was left unanswered for some time due to time constraints for people helping out on this library. In an attempt to revive the project I'm trying to do some triage on the issues and pull requests.

Your additional test case seems correct, although the file it has been put in seems a bit unfitting, since there is no tupple of types being tested. It seems that ArraysTest.php would be a more fitting location?

Would you be willing to spend the effort in order to get this PR considered ready for merging?

DannyvdSluijs avatar Feb 12 '24 20:02 DannyvdSluijs

@dafeder could you perhaps give this a final glance. I've been cleaning up the PR from unwanted commits and done a rebase on the current master 47708f5

DannyvdSluijs avatar May 27 '24 20:05 DannyvdSluijs

@snapshotpl thanks for your efforts.

DannyvdSluijs avatar Sep 20 '24 11:09 DannyvdSluijs