website icon indicating copy to clipboard operation
website copied to clipboard

Reference pages broken on iOS safari (invalid Regular Expression)

Open anttiviljami opened this issue 1 year ago • 14 comments

Describe the bug

How to Reproduce

Launch any reference page on iOS Safari, e.g. https://json-schema.org/understanding-json-schema/reference/string

Expected behavior

Should render the page on iOS safari

Details

Screenshot 2023-12-02 at 11 04 49 Screenshot 2023-12-02 at 11 05 40

anttiviljami avatar Dec 02 '23 10:12 anttiviljami

Hey @anttiviljami Firstly thanks for reporting. Secondly, can you let me know specifically what version of iOS you're using here please? =]

Relequestual avatar Dec 02 '23 23:12 Relequestual

5A928B24-5BEA-4E6D-9799-5DB6168BDD4F

anttiviljami avatar Dec 03 '23 07:12 anttiviljami

i am not able to reproduce this in my macbook/safari.

benjagm avatar Dec 03 '23 12:12 benjagm

I experience the same in my MacBook air Safari. None of the navbar items can be rendered:

image

In Chrome it works fine.

I'm on Catalina (...yes still).

kayx23 avatar Dec 08 '23 00:12 kayx23

Thanks for filling @anttiviljami and @kayx23 ! Can you please check if the issue has been fixed here: https://6ca79aae.website-2v2.pages.dev/understanding-json-schema/reference/string

benjagm avatar Dec 08 '23 09:12 benjagm

@benjagm still happening for me

image

image

kayx23 avatar Dec 08 '23 22:12 kayx23

It looks like lookbehind support was added in Safari 16.4. I assume this means iOS 16.4 onwards too. Relevant PR: https://github.com/WebKit/WebKit/pull/7109

If are are able to update, this would be ideal. If anyone else is able to identify and fix the problem, we would welcome a further PR.

Relequestual avatar Jan 09 '24 14:01 Relequestual

@benjagm It would be great if you can assign this issue to me. i’ll start on it

MonalSD avatar Feb 27 '24 12:02 MonalSD

This is a difficult one @MonalSD . All yours.

I tried myself in this draft PR but it didn't work: https://github.com/json-schema-org/website/pull/257

benjagm avatar Feb 27 '24 16:02 benjagm

@benjagm I tried but couldn't reach to the desired solution. Thankyou

MonalSD avatar Mar 10 '24 04:03 MonalSD

Thanks Monal! This is a really difficult bug. I also spent some days working on it too so .... thanks for trying!

benjagm avatar Mar 10 '24 09:03 benjagm

Hello @benjagm,

Has there been any other release to fix this bug? I'd love to give it s shot.

Starting with reproducing the error across my devices.

vickywane avatar Apr 18 '24 00:04 vickywane

Has there been any other release to fix this bug?

No. We could not fix it. Thanks a lot for your interest on this one.

benjagm avatar Apr 18 '24 08:04 benjagm

Hello! :wave:

This issue has been automatically marked as stale due to inactivity :sleeping:

It will be closed in 180 days if no further activity occurs. To keep it active, please add a comment with more details.

There can be many reasons why a specific issue has no activity. The most probable cause is a lack of time, not a lack of interest.

Let us figure out together how to push this issue forward. Connect with us through our slack channel : https://json-schema.org/slack

Thank you for your patience :heart:

github-actions[bot] avatar Jun 02 '24 00:06 github-actions[bot]

This issue did not get any activity in the past 180 days and thus has been closed. Please check if the main branch has fixed it. Please, create a new issue if the issue is not fixed.

github-actions[bot] avatar Dec 01 '24 02:12 github-actions[bot]