website icon indicating copy to clipboard operation
website copied to clipboard

fix: ensure Media Partner image renders consistently across themes

Open nandu-99 opened this issue 1 month ago • 6 comments

What kind of change does this PR introduce? Bugfix — ensures the "Dev Events" Media Partner image loads properly in both light and dark modes, including after page reloads.

Issue Number: Closes #1925

Screenshots/videos: Screenshot 2025-11-17 at 10 00 41 AM Screenshot 2025-11-17 at 4 40 24 PM

If relevant, did you update the documentation? Not needed — no documentation changes required.

Summary This PR fixes an issue where the “Dev Events” image under the Media Partner section failed to render in light mode after a page reload, despite displaying correctly in dark mode.

Does this PR introduce a breaking change? No — this fix is fully backward-compatible.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

  • [x] I have read, understood, and followed the [contributing guidelines](https://github.com/json-schema-org/website/blob/main/CONTRIBUTING.md).
  • [x] I have tested the fix in both light and dark modes.
  • [x] I have verified that the image renders correctly after a page reload.
  • [x] I have added screenshots where applicable.

nandu-99 avatar Nov 17 '25 11:11 nandu-99

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
website ✅ Ready (View Log) Visit Preview 2cc49259849c6f4178d661d450466345407b915c

github-actions[bot] avatar Nov 17 '25 11:11 github-actions[bot]

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 100.00%. Comparing base (1a2d4a6) to head (2cc4925).

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1928   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           30        30           
  Lines          633       633           
  Branches       196       196           
=========================================
  Hits           633       633           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Nov 17 '25 11:11 codecov[bot]

Hi @Honyii , do we have any logo for Dev events for light theme ?

Utkarsh-123github avatar Nov 19 '25 04:11 Utkarsh-123github

No I didn't have the light mode design for dev events @Utkarsh-123github , @nandu-99 thanks for bringing this up and your enthusiasm is commendable!

Honyii avatar Nov 19 '25 21:11 Honyii

@Honyii Thank you

nandu-99 avatar Nov 22 '25 06:11 nandu-99

Thanks Honyii for the clarification.

Utkarsh-123github avatar Nov 22 '25 13:11 Utkarsh-123github