website icon indicating copy to clipboard operation
website copied to clipboard

Consistent-use-of-Image-component

Open vishwansh01 opened this issue 1 month ago • 14 comments

What kind of change does this PR introduce? Changes img tags with Image tags in all .tsx files

Issue Number:

  • Closes #1885

Screenshots/videos: image

Summary Relpaced all the img tag with Image tags in

  • pages/index.page.tsx
  • pages/overview/pro-help/index.page.tsx
  • components/ui/AmbassadorsList.tsx

Does this PR introduce a breaking change? No

Checklist

Please ensure the following tasks are completed before submitting this pull request.

vishwansh01 avatar Nov 08 '25 18:11 vishwansh01

Hi @vishwansh01! Thanks a lot for your contribution!

I noticed that the following required information is missing or incomplete: kind of change description

Please update the PR description to include this information. You can find placeholders in the PR template for these items.

Thanks a lot!

github-actions[bot] avatar Nov 08 '25 18:11 github-actions[bot]

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
website ✅ Ready (View Log) Visit Preview 644b08388111c6dca6b4b68b6ddd73a67729f05d

github-actions[bot] avatar Nov 08 '25 18:11 github-actions[bot]

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 100.00%. Comparing base (3bf407c) to head (644b083).

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1897   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           30        30           
  Lines          633       633           
  Branches       196       196           
=========================================
  Hits           633       633           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Nov 08 '25 18:11 codecov[bot]

Hey @Utkarsh-123github , whenever you have some time, could you take a look at this?

vishwansh01 avatar Nov 11 '25 07:11 vishwansh01

Hii @vishwansh01, can you see please checkout https://github.com/json-schema-org/website/issues/1943, are things similar or can that issue be covered in this PR itself. Please let me know.

vtushar06 avatar Nov 22 '25 01:11 vtushar06

Hii @vtushar06 I looked at #1943 , it’s the same issue and can be folded into this PR. I’ll add the fixes here and push a follow up commit.

vishwansh01 avatar Nov 22 '25 11:11 vishwansh01

Hi @vishwansh01 , thank you for your contribution. Whenever you push the latest changes, tag me and I'll review the changes.

Utkarsh-123github avatar Nov 22 '25 12:11 Utkarsh-123github

Got cypress error in Layout.cy.tsx due to tailwind css changes. Changed it to fix the error image

vishwansh01 avatar Nov 22 '25 20:11 vishwansh01

Modified all files using image tags instead of inline css. modified: components/Layout.tsx modified: pages/blog/posts/[slug].page.tsx modified: pages/community/index.page.tsx modified: pages/index.page.tsx modified: pages/blog/index.page.tsx modified: cypress/components/Layout.cy.tsx

vishwansh01 avatar Nov 22 '25 20:11 vishwansh01

@Utkarsh-123github , Could you please review this?

vishwansh01 avatar Nov 22 '25 21:11 vishwansh01

Hi Utkarsh, I have pulled the changes. Could you please review it ?

vishwansh01 avatar Nov 24 '25 15:11 vishwansh01

Hii @vishwansh01, have you made changes also for issue #1943?

vtushar06 avatar Nov 25 '25 01:11 vtushar06

Hii @vtushar06, I have made changes for issue #1943 . Not just blog posts, I replaced all the CSS backgrounds using inline style={{ backgroundImage: ... }} with Image tag.

vishwansh01 avatar Nov 25 '25 05:11 vishwansh01

Thanks @vishwansh01.

vtushar06 avatar Nov 25 '25 06:11 vtushar06