website icon indicating copy to clipboard operation
website copied to clipboard

Fix mobile navigation overflow

Open vtushar06 opened this issue 4 months ago • 8 comments

What kind of change does this PR introduce? Bugfix - Fixed mobile navigation overflow issue and improved accordion behavior

Issue Number:

  • Closes #1797

Screenshots/videos:

  • Before fix: Navigation dropdowns were overflowing on mobile and multiple sections could be open simultaneously, causing layout issues.

https://github.com/user-attachments/assets/c9767316-a9cf-4812-b853-d680745211c6

  • After fix: Only one accordion section can be open at a time, preventing overflow and improving mobile UX.

https://github.com/user-attachments/assets/c2a3450c-7d67-4f32-b6a3-6bed063b96fb

If relevant, did you update the documentation?

  • No

Summary This PR fixes the mobile responsiveness issue reported in #1797 where the left navigation drawer's dropdown menus were overflowing from their parent container on mobile devices, breaking the layout and negatively impacting user experience.

Key changes made:

  1. Fixed typo: Corrected pathWtihoutFragment to pathWithoutFragment throughout the component
  2. Improved accordion behavior: Implemented handleAccordion function to ensure only one navigation section can be open at a time
  3. Enhanced mobile UX: Prevents content overflow by closing other sections when a new one is opened

Does this PR introduce a breaking change? No, this is a backward-compatible fix that only improves the existing navigation behavior without changing any APIs or interfaces.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

vtushar06 avatar Aug 08 '25 11:08 vtushar06

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
website ✅ Ready (View Log) Visit Preview 09e65a7b8aadfe616e400bbb0364079ff48b7292

github-actions[bot] avatar Aug 08 '25 11:08 github-actions[bot]

Hii @benjagm & @Utkarsh-123github, can you please review this PR. Thanks

vtushar06 avatar Aug 08 '25 17:08 vtushar06

Hi @vtushar06 , before I review this PR, it would be great if you please fix this failing check. Thank you!

Utkarsh-123github avatar Aug 08 '25 18:08 Utkarsh-123github

yes @Utkarsh-123github, I tried fixing it, and can you help me out in fixing that.

vtushar06 avatar Aug 08 '25 22:08 vtushar06

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :warning: Please upload report for BASE (main@e97ceb0). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff            @@
##             main     #1811   +/-   ##
========================================
  Coverage        ?   100.00%           
========================================
  Files           ?        30           
  Lines           ?       633           
  Branches        ?       196           
========================================
  Hits            ?       633           
  Misses          ?         0           
  Partials        ?         0           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Aug 08 '25 23:08 codecov[bot]

@Utkarsh-123github can you take a look into this, if in case any more changes required.

vtushar06 avatar Aug 09 '25 01:08 vtushar06

great job, LGTM👍

idanidan29 avatar Aug 13 '25 07:08 idanidan29

Thanks @idanidan29👍

vtushar06 avatar Aug 13 '25 14:08 vtushar06