website icon indicating copy to clipboard operation
website copied to clipboard

Enhancement: Unnecessary Vertical Scrollbar Appears on https://json-schema.org/docs

Open Deepak-cell311 opened this issue 7 months ago • 7 comments

On the https://json-schema.org/docs page of the JSON Schema website.

Issue:

When opening pages like the one shown in the attached screenshot, the left sidebar (Reference section) and the right side of the viewport both show visible vertical scrollbars, the page doesn’t initially fit within the viewport, so the appearance of the scrollbar is expected and justified. However, my intention is to allow scrolling behavior without showing the visible scrollbar, in order to enhance the visual polish of the UI — especially in dark mode.

Goal:

The goal is to retain the scrolling functionality while hiding the scrollbars, creating a smoother and cleaner appearance

Before

Image

After

Image

Are you working on this issue?

Yes

Does this PR introduce a breaking change?

No

Checklist

Please ensure the following tasks are completed before submitting this pull request.

Deepak-cell311 avatar May 16 '25 14:05 Deepak-cell311

Welcome to the JSON Schema Community. We are so excited you are here! Thanks a lot for reporting your first issue!! 🎉🎉 Please make sure to take a look at our contributors guide if you plan on opening a pull request. For more details, check out the README.md file.

github-actions[bot] avatar May 16 '25 14:05 github-actions[bot]

Hey @DhairyaMajmudar , kindly have a look over this issue, and if approved then please assign this to me. Thank you 🚀

Deepak-cell311 avatar May 16 '25 14:05 Deepak-cell311

Hey @Deepak-cell311, I hope you're doing well. I understand that contributing to a project can be really exciting, and it's great to see your enthusiasm in creating issues or pull requests. However, I kindly request that you avoid tagging others unnecessarily unless it's truly important, as everyone has their own responsibilities and workload. Also, please note that if there’s no activity on this issue for a certain period of time, it may either be closed automatically or reviewed by a maintainer accordingly.

Thanks for your understanding and contributions!

jagpreetrahi avatar May 17 '25 08:05 jagpreetrahi

Hey @Deepak-cell311 , can you elaborate a bit more about the issue? If I am not wrong, the page which you mentioned doesn't gets fit initially within the viewport, so I think a scrollbar is justifying this case.

Utkarsh-123github avatar May 17 '25 14:05 Utkarsh-123github

Hey @Deepak-cell311 , can you elaborate a bit more about the issue? If I am not wrong, the page which you mentioned doesn't gets fit initially within the viewport, so I think a scrollbar is justifying this case.

Yes, you're absolutely right — the page doesn't initially fit within the viewport, so the scrollbar appears as expected. However, my intention is to hide the scrollbar while still allowing the scrolling behavior to work.

Deepak-cell311 avatar May 17 '25 14:05 Deepak-cell311

Got it. So I think you need to modify your issue description first because it isn't clear enough. Also before raising a PR, please wait and let maintainers assign this issue to you.

Utkarsh-123github avatar May 17 '25 14:05 Utkarsh-123github

Got it. So I think you need to modify your issue description first because it isn't clear enough. Also before raising a PR, please wait and let maintainers assign this issue to you.

Thank you for correction and feedback.

Deepak-cell311 avatar May 17 '25 14:05 Deepak-cell311

@Deepak-cell311 please go ahead with the changes.

benjagm avatar Jun 14 '25 09:06 benjagm

@Deepak-cell311 please go ahead with the changes.

Thank you

Deepak-cell311 avatar Jun 14 '25 15:06 Deepak-cell311

@Deepak-cell311 are you still working on this if not I would love to fix this issue

animeshsahoo1 avatar Jul 08 '25 13:07 animeshsahoo1

@Deepak-cell311 are you still working on this if not I would love to fix this issue

Yes if you want

Deepak-cell311 avatar Jul 08 '25 14:07 Deepak-cell311

thanks for the reply, @Utkarsh-123github could you assign this issue to me I would like to fix it.

animeshsahoo1 avatar Jul 08 '25 14:07 animeshsahoo1

Hey @animeshsahoo1 , for this issue @Deepak-cell311 has already raised a PR and I have requested some small changes there.

@Deepak-cell311 are you still available to work on your previous PR ??

Utkarsh-123github avatar Jul 08 '25 15:07 Utkarsh-123github

I think @Deepak-cell311 is unable to work on it for some reason, If he doesn't intend to go through his PR, I can drop a PR with the requested changes, let me know what's decided.

animeshsahoo1 avatar Jul 08 '25 15:07 animeshsahoo1

Hey @animeshsahoo1 , for this issue @Deepak-cell311 has already raised a PR and I have requested some small changes there.

@Deepak-cell311 are you still available to work on your previous PR ??

I’d really like to work on it, but at the moment I’m caught up with several other commitments. Please assign this to @animeshsahoo1 for now.

Deepak-cell311 avatar Jul 08 '25 15:07 Deepak-cell311

Thank you for the clarification.I'm closing your PR and assigning this issue to @animeshsahoo1 .

Utkarsh-123github avatar Jul 08 '25 15:07 Utkarsh-123github

@Utkarsh-123github there is similar issue in tools pages as well should I fix it there as well?

animeshsahoo1 avatar Jul 08 '25 16:07 animeshsahoo1

Yes, please go ahead. Thank you!

Utkarsh-123github avatar Jul 09 '25 02:07 Utkarsh-123github