Fixing the Navigation is not working in the blog in Japanese
Closes #1614
What kind of change does this PR introduce?
This PR fixes a bug where in-page navigation (e.g., table of contents or anchor links) was not working in the Japanese version of the blog. The root cause was that the slugifyMarkdownHeadline function did not correctly handle non-Latin characters like Japanese, resulting in empty or malformed slugs.
Checklist
- [x] I have linked a related issue using
Closes #1614 - [x] I have described the kind of change made
- [x] I have tested the feature in both English and Japanese blog versions
- [x] I have ensured slugs generate correctly for Unicode characters
- [x] I have verified anchor links are working as expected
@benjagm
Hi @Deepak-cell311! Thanks a lot for your contribution!
I noticed that the following required information is missing or incomplete: issue reference, kind of change description
Please update the PR description to include this information. You can find placeholders in the PR template for these items.
Thanks a lot!
built with Refined Cloudflare Pages Action
âš¡ Cloudflare Pages Deployment
| Name | Status | Preview | Last Commit |
|---|---|---|---|
| website | ✅ Ready (View Log) | Visit Preview | a67c7b1bd4a049cb44d5f51e4be61eb35d281dd9 |
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 100.00%. Comparing base (
b68db4b) to head (a67c7b1). Report is 53 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #1642 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 396 396
Branches 106 106
=========================================
Hits 396 396
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
Hi @DhairyaMajmudar , Kindly have a look over and review this PR whenever you have a moment. Thank you🚀
@AQIB-NAWAB can you please review this PR instead of opening a new one?
Sure @benjagm
@Utkarsh-123github can you please help me reviewing this PR?
Also @Deepak-cell311 , a small but helpful tip for you, before raising a new PR please checkout to the main branch, perform a git pull and then create a new branch. I think the extra code changes in your PRs might have come from creating the new branch off of a different branch instead of main. Hope this helps! 😊
Closing this PR based on contributor's comment https://github.com/json-schema-org/website/issues/1662#issuecomment-3049430871