website icon indicating copy to clipboard operation
website copied to clipboard

🐛 Bug: Navigatoin is not working in the blog in Japanese

Open AQIB-NAWAB opened this issue 8 months ago • 2 comments

Describe the bug

The Navigation is not working in blog which is in Japanese Language.

Steps To Reproduce

  1. Go to https://json-schema.org/blog/posts/cookpad-case-study-jp
  2. Click on the navigation link in sidebar it will not work

Expected Behavior

https://github.com/user-attachments/assets/077ce627-8d28-4c4f-8088-fe4a0cd244cb

Screenshots

No response

Device Information [optional]

- OS: Ubuntu/Linux
- Browser: Firefox
- version: 137.0.1

Are you working on this issue?

Yes

Do you think this work might require an [Architectural Decision Record (ADR)]? (significant or noteworthy)

No

AQIB-NAWAB avatar Apr 11 '25 08:04 AQIB-NAWAB

The reasons it is not working because the slugifyMarkdownHeadline is only working for English due the regix written there. I have already solved on local so please assign this issue to me.

Thanks

CC : @DhairyaMajmudar @benjagm

AQIB-NAWAB avatar Apr 11 '25 08:04 AQIB-NAWAB

Hi @benjagm , please assign this issue to me. Thanks

AQIB-NAWAB avatar Apr 29 '25 17:04 AQIB-NAWAB

Thanks @AQIB-NAWAB . Please go ahead with the PR.

benjagm avatar Jun 14 '25 10:06 benjagm

@Utkarsh-123github is this Issue still available for fixing? since for some reason as said described earlier in another issue Deepak is unable to work currently I can add the necessary changes if @AQIB-NAWAB is also not currently working on this, let me know what's the decision.

animeshsahoo1 avatar Jul 08 '25 16:07 animeshsahoo1

Hi @AQIB-NAWAB , hope you're doing well. Are you currently working on this issue, or do you need any help regarding this ?

Utkarsh-123github avatar Jul 09 '25 02:07 Utkarsh-123github

Hi @AQIB-NAWAB , hope you're doing well. Are you currently working on this issue, or do you need any help regarding this ?

Hi @Utkarsh-123github , I'm not working on this one because benjamin told me that there is another PR which is resolving this issue so instead of making another PR let's review that PR.

AQIB-NAWAB avatar Jul 09 '25 02:07 AQIB-NAWAB

You're right, and I have reviewed it too. But I guess the contributor is unable to further make the changes as per this comment https://github.com/json-schema-org/website/issues/1662#issuecomment-3049430871 . In that case are you still willing to work on it ?

Utkarsh-123github avatar Jul 09 '25 02:07 Utkarsh-123github

You're right, and I have reviewed it too. But I guess the contributor is unable to further make the changes as per this comment #1662 (comment) . In that case are you still willing to work on it ?

Yeah why not , I am up for this. I will drop PR by tomorrow.

AQIB-NAWAB avatar Jul 09 '25 03:07 AQIB-NAWAB

Thanks @AQIB-NAWAB ! Please go ahead with the PR.

Utkarsh-123github avatar Jul 09 '25 03:07 Utkarsh-123github

Hi @Utkarsh-123github , I made a PR. can you review it please. Thanks

AQIB-NAWAB avatar Jul 09 '25 05:07 AQIB-NAWAB