website icon indicating copy to clipboard operation
website copied to clipboard

Add Table of Contents component to documentation layout

Open techmannih opened this issue 9 months ago • 5 comments

What kind of change does this PR introduce? Add Table of Contents component to documentation layout

Issue Number:

  • Closes #1109

techmannih avatar Mar 06 '25 05:03 techmannih

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
website ✅ Ready (View Log) Visit Preview 6a61d7086b574e042211c71f09afd7493cda013d

github-actions[bot] avatar Mar 06 '25 09:03 github-actions[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (219521e) to head (6a61d70).

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1471   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          396       396           
  Branches       106       106           
=========================================
  Hits           396       396           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Mar 06 '25 09:03 codecov[bot]

@DhairyaMajmudar please review now

techmannih avatar Mar 13 '25 03:03 techmannih

Let's review this once Dhairya's feedback is addressed.

DarhkVoyd avatar Mar 23 '25 16:03 DarhkVoyd

@DhairyaMajmudar I’ve updated the code with the changes. However, I have a doubt about one point — I didn’t quite understand what you meant by the “gap between TOC and footer.” Could you please explain it a bit more if the issue is still there?

techmannih avatar Apr 10 '25 12:04 techmannih

Hi @techmannih , as per Benjamin's comment: https://github.com/json-schema-org/website/issues/1109#issuecomment-2924815503 , the issue corresponding to this PR will be covered in GSoC Project #1654 , so I think we can close this PR.

Utkarsh-123github avatar Jun 02 '25 03:06 Utkarsh-123github

Closed as discussed. Thanks a lot for your hard work @techmannih

benjagm avatar Jun 12 '25 04:06 benjagm