website icon indicating copy to clipboard operation
website copied to clipboard

fix: arrow svg compatible with dark mode and responsiveness of text

Open Karan-Palan opened this issue 9 months ago • 3 comments

What kind of change does this PR introduce?

  • Improved the color contrast of arrows in "Go Back" and "Up Next" buttons in dark mode. (used #2563EB for Arrow svg i.e color used for hyperlinks across the website)
  • Ensured consistent vertical stacking and alignment of text and arrows across screen sizes.

Issue Number:

  • Closes #1292

Screenshots/videos:

Screenshot from 2025-03-06 04-55-00

If relevant, did you update the documentation?

No

Summary

Does this PR introduce a breaking change?

Karan-Palan avatar Mar 05 '25 23:03 Karan-Palan

built with Refined Cloudflare Pages Action

âš¡ Cloudflare Pages Deployment

Name Status Preview Last Commit
website ✅ Ready (View Log) Visit Preview 32c8a11c24165d46c2a01fc931ba45491af5845e

github-actions[bot] avatar Mar 05 '25 23:03 github-actions[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (60f2d6a) to head (32c8a11). Report is 49 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1468   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          396       396           
  Branches       106       106           
=========================================
  Hits           396       396           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Mar 05 '25 23:03 codecov[bot]

Based on https://github.com/json-schema-org/website/issues/1292#issuecomment-2709607367, made these changes:

Screencast from 2025-03-16 14-30-04.webm

@DhairyaMajmudar , ptal

Karan-Palan avatar Mar 16 '25 09:03 Karan-Palan

Hi @Karan-Palan , as per Benjamin's comment: https://github.com/json-schema-org/website/issues/1292#issuecomment-2924815257 , I think we can close this PR. Thank you for your efforts and contribution.🚀

Utkarsh-123github avatar Jun 02 '25 03:06 Utkarsh-123github

Hi @Karan-Palan , as per Benjamin's comment: https://github.com/json-schema-org/website/issues/1292#issuecomment-2924815257 , I think we can close this PR. Thank you for your efforts and contribution.🚀

Sure, closing it!

Karan-Palan avatar Jun 02 '25 07:06 Karan-Palan