website icon indicating copy to clipboard operation
website copied to clipboard

feat: Made side panel fixed on the tooling page

Open thepiyush-303 opened this issue 11 months ago • 9 comments

What kind of change does this PR introduce?

Issue Number:

  • Closes #1279

Screenshots/videos:

Screencast from 2025-01-22 20-25-15.webm

If relevant, did you update the documentation?

Summary

Does this PR introduce a breaking change?

thepiyush-303 avatar Jan 22 '25 14:01 thepiyush-303

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
website ✅ Ready (View Log) Visit Preview a0285a16321c31171dfdca76729c3bab579b9e24

github-actions[bot] avatar Jan 22 '25 14:01 github-actions[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (60f2d6a) to head (a0285a1). Report is 49 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1359   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          396       396           
  Branches       106       106           
=========================================
  Hits           396       396           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Jan 22 '25 14:01 codecov[bot]

@DhairyaMajmudar can you please give a feedback on changes?

thepiyush-303 avatar Jan 29 '25 19:01 thepiyush-303

@DhairyaMajmudar I have made necessary changes please approve them.

thepiyush-303 avatar Jan 31 '25 19:01 thepiyush-303

Fix this overlapping

image

you can take reference from sidebar from /docs page

DhairyaMajmudar avatar Jan 31 '25 19:01 DhairyaMajmudar

Hello @benjagm I forgot checking it for smaller screen but now it is fixed. Attaching video-->

Screencast from 2025-03-06 16-33-46.webm

thepiyush-303 avatar Mar 06 '25 11:03 thepiyush-303

Hello @DhairyaMajmudar now it is fixed.

thepiyush-303 avatar Mar 10 '25 19:03 thepiyush-303

Hey @DhairyaMajmudar @benjagm Please let me know if any other changes required.

thepiyush-303 avatar Mar 20 '25 15:03 thepiyush-303

@thepiyush-303 Thank you for your patience, I'll review this tomorrow EOD.

DarhkVoyd avatar Mar 23 '25 18:03 DarhkVoyd

Hi @thepiyush-303 , as per Benjamin's comment : https://github.com/json-schema-org/website/issues/1279#issuecomment-2924812212 , I think we can close this PR. Thank you for your contribution🚀

Utkarsh-123github avatar Jun 02 '25 03:06 Utkarsh-123github

Okay, Thanks @Utkarsh-123github for letting me know. Closing it as it will be covered in GSoC2025 Project.

thepiyush-303 avatar Jun 02 '25 03:06 thepiyush-303

Yes, @thepiyush-303 please close this at your convenience.

Utkarsh-123github avatar Jun 02 '25 03:06 Utkarsh-123github