website icon indicating copy to clipboard operation
website copied to clipboard

Update CONTRIBUTING.md for better guidance for new contributors

Open benjagm opened this issue 11 months ago • 7 comments

Summary

We are making it more clear for new contributors the conditions to work on an Issue and submit a PR.

benjagm avatar Jan 07 '25 09:01 benjagm

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
website ✅ Ready (View Log) Visit Preview cbc0f510a796b25923a5d55148f7b838032447ff

github-actions[bot] avatar Jan 07 '25 09:01 github-actions[bot]

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 100.00%. Comparing base (72ae168) to head (cbc0f51). :warning: Report is 156 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1259   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          373       373           
  Branches        94        94           
=========================================
  Hits           373       373           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Jan 07 '25 09:01 codecov[bot]

I also noticed that the triage process doesn't say anything about discussing solutions to identify the actions that need to take place. The status goes from "triage" to "available". I think there should be an "in discussion" step that indicates, "Yes this is a valid issue, but we're uncertain how we want to address it. Opinions are welcome."

gregsdennis avatar Jan 07 '25 09:01 gregsdennis

I think these changes are helpful. What do you think about also modifying the PR template to add some comments which directs people to the contribution guide?

Relequestual avatar Jan 07 '25 13:01 Relequestual

Can we please merge this? @gregsdennis @Relequestual

benjagm avatar Mar 04 '25 08:03 benjagm

The suggestions we made haven't been implemented.

gregsdennis avatar Mar 04 '25 08:03 gregsdennis

Hello! :wave:

This pull request has been automatically marked as stale due to inactivity :sleeping:

It will be closed in 180 days if no further activity occurs. To keep it active, please add a comment with more details.

There can be many reasons why a specific pull request has no activity. The most probable cause is a lack of time, not a lack of interest.

Let us figure out together how to push this pull request forward. Connect with us through our slack channel : https://json-schema.org/slack

Thank you for your patience :heart:

github-actions[bot] avatar Sep 07 '25 02:09 github-actions[bot]