json-schema-spec icon indicating copy to clipboard operation
json-schema-spec copied to clipboard

Regex editorial improvements, and permit "."

Open lukem opened this issue 2 years ago • 4 comments

Add "." to the permitted simple atoms, for issue #1469. Consistently format the regex examples.

lukem avatar Nov 11 '23 02:11 lukem

We've discussed this before, and I think it may be worth bringing it up again.

IETF has now published https://datatracker.ietf.org/doc/rfc9485/ to support interoperable regex in JSON Path. It may be wise to reconsider this in place of ECMA. Doing so would mean being able to remove all of these restrictions.

gregsdennis avatar Feb 15 '24 01:02 gregsdennis

@gregsdennis I feel like I'm inclined to agree with this person's opinion that iregexp is not a good fit for JSON Schema - though I have not kept up with any changes since 2022 that may have changed that situation.

notEthan avatar Feb 19 '24 20:02 notEthan

Yeah, I hear you. But finding interoperable regex support has been a thorn in our side for a long time.

It really has no bearing on this PR, though.

gregsdennis avatar Feb 19 '24 20:02 gregsdennis

I've added 3 commits addressing various review feedback above.

lukem avatar Feb 22 '24 07:02 lukem