json-schema-spec icon indicating copy to clipboard operation
json-schema-spec copied to clipboard

Update spec to require implementations to raise an error if it encounters a dialect it doesn't understand

Open gregsdennis opened this issue 3 years ago • 2 comments

Similarly to encountering unknown keywords, implementations should raise an error for unknown dialects.

gregsdennis avatar Oct 26 '22 23:10 gregsdennis

This needs an ADR, or possibly needs to be delayed until we figure out bootstrapping more clearly. Currently, we only error out on vocabularies, not dialects, and my sense is that the granularity of these concepts is in flux. We should figure out what the actual granularity of control is, and where that control is located, before trying to set the requirements in the spec.

handrews avatar Oct 27 '22 00:10 handrews

I think the way I used the term "dialect" might have led to some misunderstanding of the purpose of this issue. What I meant was that the implementation must raise an error if it doesn't fully understand what set of keywords are part of the dialect. That should be a concept independent of the details of bootstrapping and the vocabulary system.

I don't remember exactly what the spec currently says about this kind of thing, but I imagine that most if not all of it is already covered. However, my guess is that it's currently written in a way that is coupled to the vocabulary system and should probably be rewritten in a way that's more generic so we don't need to change the wording as the vocabulary system evolves.

jdesrosiers avatar Oct 27 '22 20:10 jdesrosiers

This needs to be a consideration for whatever vocabularies ends up being. See #1510

gregsdennis avatar Jun 18 '24 20:06 gregsdennis