json-schema-spec icon indicating copy to clipboard operation
json-schema-spec copied to clipboard

Replace defunct Travis CI integration with GitHub Actions

Open jviotti opened this issue 3 years ago • 2 comments

The GitHub Actions setup is equivalent to the Travis CI configuration with two differences:

  • The GitHub Action setup does not set the TAG environment variable, as it didn't seem like xml2rfc would consume that at all (unless I'm missing something)

  • The GitHub Action preserves the spec output (txt and html) as artifacts that can be downloaded after a successful run (to see the changes without having to locally render the specs)

Fixes: https://github.com/json-schema-org/json-schema-spec/issues/1262 Signed-off-by: Juan Cruz Viotti [email protected]

jviotti avatar Aug 05 '22 12:08 jviotti

@Relequestual I think you might need to enable the repository to run GitHub Actions from forks to be able to test this out. Once it is merged, we should also make this check required.

jviotti avatar Aug 05 '22 12:08 jviotti

What I've had to do in json-everything is merge fork PRs into a secondary branch, just to get all of the actions to run properly (even when you get them running, they don't always have all the permissions they need). Then I have another PR to pull into the primary branch.

gregsdennis avatar Aug 05 '22 13:08 gregsdennis

I believe this will also upload requirements.txt to the artifact bundle.

Relequestual avatar Aug 15 '22 09:08 Relequestual

Good catch @Relequestual ! Fixed.

jviotti avatar Aug 15 '22 13:08 jviotti

I decided to merge this immediatly as our current CI simply doesn't work.

Relequestual avatar Aug 19 '22 09:08 Relequestual