community icon indicating copy to clipboard operation
community copied to clipboard

Add JSON schema for ambassadors.json

Open DavidBiesack opened this issue 1 year ago • 6 comments

Work Summary:

I suggest this repository include a JSON Schema next to the programs/ambassadors/ambassadors.json file (such asprograms/ambassadors/ambassadors-schema.json ). When adding a submission, I was not sure what values I can use for contribution.type - a schema would tell me if it is an enum or an open string value :slightly_smiling_face:

Completing this work will mean contributors know how to submit a PR. Plus, this will highlight a good use of JSON Schema.

Do you think this work might require an Architectural Decision Record (ADR)? (significant or noteworthy)

No

Work Detail:

  • [ ] add a JSON Schema for the ambassadors.json file
  • [ ] Add a github action to validate the ambassadors.json file against the schema

DavidBiesack avatar Jun 14 '24 15:06 DavidBiesack

Great idea David. Thanks!

@ramishj are you available to work on this?

benjagm avatar Jun 19 '24 10:06 benjagm

yes i have already done it should i push it ? Assign me i will push it

ramishj avatar Jun 19 '24 11:06 ramishj

Can you assign it to me?

ramishj avatar Jun 19 '24 17:06 ramishj

All yours @ramishj . Thanks a lot for your support!

benjagm avatar Jun 19 '24 18:06 benjagm

All yours @ramishj . Thanks a lot for your support!

Your Welcome

ramishj avatar Jun 25 '24 09:06 ramishj

Hello! :wave:

This issue has been automatically marked as stale due to inactivity :sleeping:

It will be closed in 180 days if no further activity occurs. To keep it active, please add a comment with more details.

There can be many reasons why a specific issue has no activity. The most probable cause is a lack of time, not a lack of interest.

Let us figure out together how to push this issue forward. Connect with us through our slack channel : https://json-schema.org/slack

Thank you for your patience :heart:

github-actions[bot] avatar Jul 28 '24 00:07 github-actions[bot]

It looks like this work is done! @DavidBiesack can you look and confirm if you're happy with the merged PR associated with this Issue please =D

Relequestual avatar Dec 12 '24 10:12 Relequestual

Thank you!

DavidBiesack avatar Dec 12 '24 12:12 DavidBiesack