JSON-Schema-Test-Suite icon indicating copy to clipboard operation
JSON-Schema-Test-Suite copied to clipboard

draft-07: more relative JSON pointer tests

Open handrews opened this issue 7 years ago • 8 comments

They should probably include analogues of all of the absolute JSON Pointer tests from the JSON Pointer spec test case list. And there may be some other specific relative pointer cases to find and add as well.

handrews avatar Nov 19 '17 00:11 handrews

#245 is related.

Julian avatar Nov 30 '19 14:11 Julian

@Julian, I believe this one needs to be closed, as it seems to be realted to this issue, if I'm not mistaken.

MeastroZI avatar Apr 06 '24 15:04 MeastroZI

Thanks, that's the issue I mentioned previously here it looks like. The remaining work would have been verifying the rest of what's here -- i.e. that we have all the absolute pointer tests analogued in the relative tests. Have you checked that as well?

Julian avatar Apr 06 '24 15:04 Julian

@Julian, it appears that escape characters are not covered in RJP. Could I work on that, if I am not misunderstanding it?

MeastroZI avatar Apr 06 '24 17:04 MeastroZI

Ex: this and all subsequent tests are not covered in RJP.

MeastroZI avatar Apr 08 '24 03:04 MeastroZI

I'm on vacation so it will take me a few weeks to look -- but I'd say if you've found some tests which look missing, send a PR and someone will likely review (likely before I'm even fully looking at things).

Julian avatar Apr 09 '24 07:04 Julian

Thanks for your reply @Julian and sorry for disturb. enjoy your vacataion :)

MeastroZI avatar Apr 09 '24 07:04 MeastroZI

@Julian just one question , if i am not wrong RJP also need to be include the tests with escape characters which are in absolute json pointer ? like this one

 {
                "description": "valid JSON-pointer as stated in RFC 6901 #5",
                "data": "/a~1b",
                "valid": true
}

MeastroZI avatar Apr 18 '24 04:04 MeastroZI