angular-schema-form icon indicating copy to clipboard operation
angular-schema-form copied to clipboard

Add Object.assign polyfill or backwards compatibility library for IE support

Open Anthropic opened this issue 8 years ago • 5 comments

Enhancement

Add Object.assign polyfill or backwards compatibility module for IE support.

This can be either a script for supporting legacy browsers or included by default, that shall depend on the need for any other polyfills to support IE11

Awaiting feedback from @donalmurtagh @ramakrij @shravanmahankali @krptodr :)

Related issues

This is related to #864.

@json-schema-form/angular-schema-form-lead

Anthropic avatar Apr 25 '17 13:04 Anthropic

I'll test out the latest alpha with this polyfill. It'll likely have to wait until next week though, as I'm on vacation for 2nd half of this week

donalmurtagh avatar Apr 25 '17 13:04 donalmurtagh

I can confirm the polyFill resolves the issue with Internet Explorer 11. The form seems to load properly. However, it appears there is an issue with ngCloaking when rendering the form. This could be related to the polyFill implementation OR Alpha.5

krptodr avatar May 05 '17 15:05 krptodr

@krptodr can you describe what you mean regarding ngCloaking issue, what is happening that shouldn't?

Anthropic avatar May 05 '17 17:05 Anthropic

@Anthropic It seems like the cloaking doesn't work. You can see the {{modelvalues}} while the form is rendering.

krptodr avatar May 05 '17 18:05 krptodr

I assume you are meaning while using ng-cloak or just without but while it loads? I think $ref support making it async has some unintended side effects like that which need to be looked into.

Anthropic avatar May 07 '17 13:05 Anthropic