angular-schema-form icon indicating copy to clipboard operation
angular-schema-form copied to clipboard

Angular 2+ support

Open mmc41 opened this issue 8 years ago • 40 comments

Now that Angular2 has been released, is there any plans to port angular-schema-form to Angular 2 ?

mmc41 avatar Sep 28 '16 18:09 mmc41

Absolutely, we are already looking into it. Hard to give a timeline, but we have a few avenues we are looking at on the best way to proceed.

Anthropic avatar Sep 29 '16 00:09 Anthropic

@Anthropic Ok. I guess I need to roll my own solution than of my Angular2 app (in fact already stated) I only need to support a subset of the functionality with a custom non-bootstrap gui anyway + I am using typescript 2.0 (not plain js). If it makes sense, we could work together but properly not easy to align requirements, time, architecture-ideas etc.

mmc41 avatar Sep 29 '16 11:09 mmc41

Or, could a hybrid Angular 1 + 2 model be used meanwhile? We already use a v2 application and I guess that Angular's UpgradeAdapter may work to integrate v1 directives like schema form. Does anyone have a working simple example how this could be achieved?

jazzmanro avatar Sep 29 '16 14:09 jazzmanro

@mmc41 @jazzmanro I have already heard of people using the upgrade adapter to use it within an ng2 app.

Anthropic avatar Oct 03 '16 04:10 Anthropic

Would be so great if anyone could post a simple working example, even if it uses other library than schema form. My lack of Angular experience gave me too many headaches when trying this, without success so far.

jazzmanro avatar Oct 03 '16 14:10 jazzmanro

I agree with the fact that we would like to have a working example which uses the hybrid Angular 1-2 UpgradeAdapter till this project gets ported to Angular 2 completely. Can anyone help in this?

@Anthropic: Can you please try to give some estimate on the porting? How is it progressing?

bombompb avatar Oct 24 '16 17:10 bombompb

@nicklasb did you know of a hybrid version working and how ng2 would work with the form?

Anthropic avatar Oct 25 '16 05:10 Anthropic

Nb. See also "https://github.com/json-schema-form/json-schema-form-core/issues/3" for a suggestion on how to more easily retarget for various web frameworks, incl. Angular 2.

mmc41 avatar Oct 25 '16 07:10 mmc41

Here is probably a temporary alternative https://github.com/makinacorpus/angular2-schema-form Untill the angular-schema-form will be ported to Angular 2.

cheprus avatar Dec 13 '16 10:12 cheprus

@Anthropic , @mmc41 , @cheprus : It is possible to use ASF in Angular 2 with ngUpgrade for the time being.

I use it in the administrative interface for my framework: https://github.com/OptimalBPM/of-admin/wiki/App-Entry-&-Bootstrapping

nicklasb avatar Dec 13 '16 10:12 nicklasb

The admin UI is also Angular 2, BTW. Because A2 is about components, that part is kind of contained anyway, so it works well. Sure, if one starts to intertwine stuff directly, one might encounter some problems, on the other hand, that is not a very nice architectural design choice. I expect to be able to, basically, simply remove the ngUpgrade wrapper when ASF gets A2 support.

nicklasb avatar Dec 13 '16 10:12 nicklasb

Hi Any estimation for this issue?

Valery-vs avatar Jan 30 '17 08:01 Valery-vs

+1

cmartin81 avatar Jan 30 '17 14:01 cmartin81

The first alpha of the core is out, once a few more fixes and a clean API are added then ng2 work can start using it. Timelines are a bit tricky to indicate, never know how much time anyone will have. I suspect once I get the ASF alpha out shortly that there may be a few more contributors willing to help work on it.

Anthropic avatar Jan 30 '17 22:01 Anthropic

what's the status for this issue. I'm going to have spare time in the near future and I wish to help.

mathpaquette avatar May 07 '17 15:05 mathpaquette

@mathpaquette (and anyone interested in helping) can message me on Gitter. I will make a Gitter group tonight for people willing to help with progressing this.

Anthropic avatar May 08 '17 00:05 Anthropic

Hi @Anthropic where's the Gitter? Also a thing that makes me very sad is that jsonschema form as been ported to recent framework like react (react-jsonschema-form) but nobody have considered to create an intermediate lib that we can easily reuse (probably its more efforts). I saw that you created a core project but is there a real interest by the community?

mathpaquette avatar May 09 '17 12:05 mathpaquette

@mathpaquette yes there is likely to be an effort shortly to fork and port the react lib you mentioned over to use the core from here, some users want a react port that is 100% compatible using the core. I will work with them on that to ensure the core is as stable and usable as possible for any library. Gitter is linked from this repo home page but you can just go onto gitter and use my github username to find me anyway.

Anthropic avatar May 10 '17 01:05 Anthropic

@Anthropic just wondering if there's any update or progress on Angular 2+ support? Have an Angular 4 enterprise project about to kick off and ASF would make life a million times easier. Thanks!

GFoley83 avatar Aug 21 '17 22:08 GFoley83

I don't expect it to be any time too soon, I have been sick for three weeks and taken off anything form related at work, so I am struggling on time, I have one colleague at work testing several different approaches for me though and I am working on making validator selectable to remove dependence on tv4, so it isn't a stand still, Angular no longer has a $compile method so we're determining the best way to overcome that at the moment since it is used heavily in the current version. Anyway using ngupgrade is still the main option for the moment.

Anthropic avatar Aug 21 '17 23:08 Anthropic

@GFoley83 same here.

swirlsky avatar Sep 08 '17 23:09 swirlsky

Hi @Anthropic , Is there some progress on the Angular 4 implementation? Am looking really forward to it.

dmastag avatar Sep 29 '17 11:09 dmastag

@dmastag I am working on it today, there's been a break as I was sick for four weeks over the last three months with two separate cases of the flu, but I am started back into it yesterday. Timelines are hard to provide though as it is only me working on it in spare time.

Anthropic avatar Sep 30 '17 02:09 Anthropic

Hi @Anthropic , Thanks for the update. Hope that you are feeling better now. Is the work done on this repository? And is it still a huge task to do?

Maybe if the tasks can be split up into smaller jobs then the community is willing to help you on it?

dmastag avatar Sep 30 '17 04:09 dmastag

Hi, just to share in case you may not know about this project - https://github.com/dschnelldavis/angular2-json-schema-form. Perhaps can merge the effort to improve on one library.

beeing avatar Oct 01 '17 06:10 beeing

https://github.com/dschnelldavis/angular2-json-schema-form is still in alpha and development is pretty sparse. I opened an issue over a month ago asking if the project was still in active development and have yet to get a response.

I've resorted to using: https://github.com/makinacorpus/angular2-schema-form

which is stable, actively in development and seem to be doing the trick so far.

GFoley83 avatar Oct 01 '17 06:10 GFoley83

@GFoley83 agree, and it is even mentioned on the disclaimer that they think this is a great library and would like to join forces on an Angular2+ solution

https://github.com/makinacorpus/angular2-schema-form#disclaimer

dmastag avatar Oct 03 '17 08:10 dmastag

Yes I have spoken to them to get them to add the disclaimer (people were getting confused by the name and asking me support questions for it) and we will probably collaborate together in future once the core work is done. I'll give you a list later about what work there is to do, I am always happy to help get someone up to speed to work on the project if they are interested I've trained a few people already, but they all ran out of bandwidth to help before being able to get involved. It is hard while transitioning to do docs as they'd become obsolete after a few weeks at this stage, but they will come.

Anthropic avatar Oct 05 '17 00:10 Anthropic

@dmastag I'm currently working on:

  • finish streamlining the build process in the core and making it TypeScript using build based on rxjs's build process, which I am almost finished with (almost is not referring to time, but effort).
  • changing the validator in the core, tv4 is no longer supported and I want features from draft 6 and 7, I am working on making any validator supportable starting with djv and ajv.
  • They're the hardest parts, then I have to make AngularJS version pass all its tests again and document anything not backwards compatible.
  • Then migrate AngularJS version of ASF to TypeScript
  • Then migrate TS AngularJS version to TS Angular
  • Then update to include any json-schema features that we don't currently support properly or from the later drafts.

I'm always willing to provide support to anyone who wants to be a co-maintainer to teach them how to work on it, but I suspect it will be much easier and more likely once things are moved to TypeScript and it becomes a lot easier to understand, debug and build.

Anthropic avatar Oct 08 '17 13:10 Anthropic

Any updates here?

cmartin81 avatar Dec 08 '17 10:12 cmartin81