angular-schema-form icon indicating copy to clipboard operation
angular-schema-form copied to clipboard

ngAnimate doesn't work well

Open nick121212 opened this issue 9 years ago • 11 comments

2015-07-08 15 56 30

nick121212 avatar Jul 08 '15 07:07 nick121212

I just noticed this also. As soon as you include ngAnimate in your module, all the validation icons stack at that location.

screen shot 2015-07-09 at 14 26 44

alexferl avatar Jul 09 '15 18:07 alexferl

set 'has-feedback' class first. it's all right.

nick121212 avatar Jul 10 '15 00:07 nick121212

I found that emitting schemaFormRedraw event fixes the issue

$scope.$applyAsync(() => {
      $scope.$broadcast('schemaFormRedraw');
    });

aantipov avatar Jul 22 '15 08:07 aantipov

But this workaround doesn't help in some cases, unfortunately.

aantipov avatar Jul 22 '15 09:07 aantipov

Is this still an issue?

nicklasb avatar Apr 10 '16 00:04 nicklasb

@nicklasb I ran into this issue a few weeks ago. Was able to work around it with the first solution after playing around with it for a while

jseed avatar Apr 14 '16 03:04 jseed

@nick121212 can you elaborate on what you did to fix it? Perhaps create a PR?

Anthropic avatar Apr 14 '16 06:04 Anthropic

@JSeed what steps did you take, would you be able to submit a pull request?

Anthropic avatar Apr 14 '16 10:04 Anthropic

@Anthropic To get it working I set html-class to has-feedback under formDefaults in the sf-options attribute when defining my form. The code looks like this :

<form name="promptForm" ng-submit="formSubmit(promptForm)">
        <fieldset sf-schema="schema" sf-form="form" sf-model="model" sf-options="{ formDefaults: { htmlClass: 'has-feedback' } }" ng-disabled="isWaiting"></fieldset>
</form>

I could look into submitting a pull request if you'd like, as long as having this class set by default on the form is okay. Not sure if that would cause any issues or not.

jseed avatar Apr 14 '16 15:04 jseed

Thanks @JSeed, you and me both, I can't imagine it being an issue, worth checking if it is something to do with the version of bootstrap and perhaps a more recent bootstrap css would also fix the issue.

Either way a PR in the angular-schema-form-bootstrap repo would be great, we can continue discussion there and try to sort it out for everyone :)

Anthropic avatar Apr 18 '16 06:04 Anthropic

+1

brian-slate avatar Aug 09 '17 22:08 brian-slate