angular-schema-form-bootstrap icon indicating copy to clipboard operation
angular-schema-form-bootstrap copied to clipboard

proposal to fix issue #33

Open patriziotufarolo opened this issue 9 years ago • 3 comments

Description

Fix for issue #33

Fixes Related issues

#33

Checklist

  • [x] I have read and understand the CONTRIBUTIONS.md file
  • [x] I have searched for and linked related issues
  • [x] I have created test cases to ensure quick resolution of the PR is easier
  • [x] I am NOT targeting main branch
  • [x] I did NOT include the dist folder in my PR

@json-schema-form/angular-schema-form-bootstrap-lead

patriziotufarolo avatar Nov 21 '16 22:11 patriziotufarolo

Apologies @patriziotufarolo I had the wrong @ notification in the PR template so I missed this!

Thanks for taking the time to make the PR! I have now created that member group so I wont miss them in future.

Would you be in a position to update and merge the latest changes into your change, should be a clean merge? Github won't clean merge it for some reason despite none of the latest updates touching that line.

Anthropic avatar Mar 26 '17 11:03 Anthropic

Hi Anthropic, thank you for your answer. I'm looking at the repository and I see that the directory structure changed a bit (bootstrap sub directory in src for example), that may be the reason for which github doesn't let you clean merge it. In the next days I'll give a try to fix this again and make new PR

patriziotufarolo avatar Mar 26 '17 12:03 patriziotufarolo

@patriziotufarolo I made a slight change to keep both classes, if you can add that it would be great, I can do it, but I wanted to ensure you got the credit for noticing the problem :)

Anthropic avatar Mar 26 '17 13:03 Anthropic