json-ld.org icon indicating copy to clipboard operation
json-ld.org copied to clipboard

Playground permalink/shortener not working

Open dlongley opened this issue 11 years ago • 9 comments

Follow the instructions in this comment:

https://github.com/digitalbazaar/jsonld.js/issues/65#issuecomment-48359301

Then click the "Permalink" button and click the "Shorten" link. I get this url:

http://tinyurl.com/lewbnyc

Which, when followed, shows the playground with the correct input document and shows the compacted tab, however, the compaction context is lost.

Expectation: The compaction context appears and matches what was previously input.

dlongley avatar Jul 08 '14 15:07 dlongley

cc: @bollwyvl

dlongley avatar Jul 08 '14 16:07 dlongley

@dlongley Will look into it!

bollwyvl avatar Jul 08 '14 16:07 bollwyvl

I've noticed that the URL does not always update after content or tab state is changed. It often requires a reload and paste of content to update. At least on safari.

gkellogg avatar Jul 08 '14 18:07 gkellogg

The popover now only gets initialized once, and the content/title are only updated from the most-recently generated link.

Just pushed what I think will fix the issues we are seeing: http://bollwyvl.github.io/json-ld.org/playground Should resolve both flavors of flakiness, though I don't have safari handy to try here.

Will open a PR, if this looks good.

bollwyvl avatar Jul 08 '14 18:07 bollwyvl

Works for me now on the demo site.

dlongley avatar Jul 08 '14 20:07 dlongley

Sorry about the ugly commit history: can resubmit as a squash, if that is preferred.

bollwyvl avatar Jul 08 '14 21:07 bollwyvl

@bollwyvl, yeah, if it isn't too much trouble it would be better to have a cleaner history.

dlongley avatar Jul 08 '14 21:07 dlongley

@bollwyvl, actually, I looked at the commits ... it seems fine.

dlongley avatar Jul 08 '14 21:07 dlongley

Great. Just meant the 'vagrant' committer, but I'm fine with it! On Jul 8, 2014 5:39 PM, "Dave Longley" [email protected] wrote:

@bollwyvl https://github.com/bollwyvl, actually, I looked at the commits ... it seems fine.

— Reply to this email directly or view it on GitHub https://github.com/json-ld/json-ld.org/issues/354#issuecomment-48402948.

bollwyvl avatar Jul 08 '14 22:07 bollwyvl