json-ld.org icon indicating copy to clipboard operation
json-ld.org copied to clipboard

playground editor usability issues

Open davidlehn opened this issue 11 years ago • 4 comments

The new input editor on the playground has many nice features, but I've found a couple issues:

  • The feature to highlight matching braces/brackets/etc is rather annoying since it also hides your cursor. It's hard to tell where you will be typing just by looking at the editor.
  • Sometimes when typing braces, it will auto-add matching content in an unwanted way such that you have to end up removing the auto-added text.

cc: @bollwyvl

davidlehn avatar May 14 '14 20:05 davidlehn

Both easy fixes, but would like to close them and/or any other codemirror-related things together. Since we last used it to get autocmplete and highlighting, codemirror has gone to 4.x, which would be good to catch up with... but it looks like the annotations may have changed a bit.

The feature to highlight matching braces/brackets/etc is rather annoying since it also hides your cursor. It's hard to tell where you will be typing just by looking at the editor.

Agreed. For some reason, the neat theme uses the css outline property, which is gross. it can be fixed with:

.cm-s-neat .CodeMirror-matchingbracket {
  outline: none;
  font-weight: bold;
  color: #0f0 !important;
}

Sometimes when typing braces, it will auto-add matching content in an unwanted way such that you have to end up removing the auto-added text.

Subjectively, I like this feature, but it is a one-liner to disable it, and would be one less file (in the bundle) to load.

bollwyvl avatar May 15 '14 00:05 bollwyvl

I haven't tried that CSS fix yet, I was probably just looking for some way to make sure you can see both the matching bracket visual cues AND your cursor at the same time. I do like and use bracket matching cues in other editors.

I'm not against the auto bracket stuff in theory, but it just seems to get in the way sometimes. If it's just me that it bothers, I can live with it.

davidlehn avatar May 15 '14 18:05 davidlehn

Right, was just capturing my research on the css. It should get fixed sooner rather than later. Is there any other style stuff we want to capture at this time?

I'd wait to see if there is any additional sentiment for getting rid of autoCloseBrackets... and/or investigate if whether the newer version is better... i'll look into getting our stuff ported to 4.x.

bollwyvl avatar May 16 '14 01:05 bollwyvl

I like the autoCloseBrackets feature and am in favor of keeping it.

lanthaler avatar May 16 '14 10:05 lanthaler