java icon indicating copy to clipboard operation
java copied to clipboard

fix checking a surrogate pair

Open t-mangoe opened this issue 5 years ago • 2 comments

I fixed code. I think this fix solves the issue #207 . If you like, please merge.

t-mangoe avatar Apr 07 '19 08:04 t-mangoe

Codecov Report

Merging #232 into master will decrease coverage by <.01%. The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #232      +/-   ##
==========================================
- Coverage   68.46%   68.45%   -0.01%     
==========================================
  Files         107      107              
  Lines        7335     7336       +1     
  Branches     1388     1388              
==========================================
  Hits         5022     5022              
- Misses       1867     1868       +1     
  Partials      446      446
Impacted Files Coverage Δ
...ain/java/com/jsoniter/output/StreamImplString.java 53.91% <0%> (-0.48%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e48a7a1...24f9551. Read the comment docs.

codecov-io avatar Apr 07 '19 08:04 codecov-io

@t-mangoe please add tests for that case

best option would be just checking of a whole range of surrogate pairs in some loop with an assertion for each pair

plokhotnyuk avatar Apr 13 '19 09:04 plokhotnyuk