json-editor icon indicating copy to clipboard operation
json-editor copied to clipboard

Add required star when table format

Open jneiluj opened this issue 4 years ago • 6 comments

Q A
Is bugfix?
New feature? ✔️
Breaks backward-compatibility?
Tests pass? ✔️
Fixed issues
Updated README/docs?
Added CHANGELOG entry?

Add a red star to cell header in table format for Spectre theme.

jneiluj avatar May 24 '20 16:05 jneiluj

Could you add a test/use-case/example, I was unable to verify.

schmunk42 avatar May 25 '20 12:05 schmunk42

Could you add a test/use-case/example, I was unable to verify.

{
  "title": "Table with red star",
  "type": "array",
  "format": "table",
  "items": {
    "type": "object",
    "required": [
      "string1",
      "string2"
    ],
    "properties": {
      "string1": {
        "type": "string"
      },
      "string2": {
        "type": "string"
      },
      "string3": {
        "type": "string"
      }
    }
  }
}
Screenshot 2020-05-25 at 16 59 08

Tell me if more is needed.

jneiluj avatar May 25 '20 15:05 jneiluj

Could you add the required class for (all) the other themes also. I created a test here: https://github.com/json-editor/json-editor/commit/fe9923180bb6a5795e310286701bf00c5be55f1f (currently checks spectre and bootstrap4)

Branch: https://github.com/json-editor/json-editor/compare/jneiluj-enhance-spectre-theme

I think I can not push onto your PR branch.

schmunk42 avatar May 26 '20 11:05 schmunk42

status?

germanbisurgi avatar Jun 03 '20 06:06 germanbisurgi

I will do, I need time (quite busy atm).

jneiluj avatar Jun 03 '20 09:06 jneiluj

status?

afmartin3z avatar Aug 06 '21 07:08 afmartin3z