jingo-minify icon indicating copy to clipboard operation
jingo-minify copied to clipboard

Published 20 hours ago • verified publisher icon jsocol

Add unittest for #62

Open yohanboniface opened this issue 10 years ago • 3 comments

Not sure it's worth it, but now it's done ;) I've added a hard coded JAVA_BIN=java through override_settings, which is not that elegant, but I've had no better idea (unless mocking). Also, to make the tests runs, I've tweaked a little bit the settings (but not pushed) for django 1.6: STATIC_URL missing a final /, added a missing SECRET_KEY, this kind of things. Not sure how you run your tests though ;)

Thanks :)

Yohan

yohanboniface avatar Apr 07 '14 13:04 yohanboniface

Oh it looks like this identified another path the tests are missing. I (or @cvan) can take some time to fix that up and get this in, but it'll probably be a little while.

jsocol avatar Apr 07 '14 16:04 jsocol

Shouldn't we just add GitPython in the requirements? Or are you referring to another issue?

yohanboniface avatar Apr 07 '14 18:04 yohanboniface

Yes, I'm just curious if that's going to open a can of worms because this is a pretty significant area of code that has apparently never been hit by tests.

jsocol avatar Apr 07 '14 18:04 jsocol