Johannes Meixner
Johannes Meixner
@markbertolin can you show us the output of the command ``` # lsblk -ipo NAME,KNAME,PKNAME,TRAN,TYPE,FSTYPE,LABEL,SIZE,MOUNTPOINT,UUID,WWN ``` on you original system and also on your replacement system - you may run...
According to https://github.com/rear/rear/pull/2819#issuecomment-1166895246 it seems the ReaR mailing lists that are shown at http://relax-and-recover.org/development/ are provided by the mail system at host service.3ti.be @gdha can you help with mail issues...
@pcahyna because this issue is about RHEL could you have a look here as far as time permits?
I would like to emphasise the "no false positives" acceptance criteria: In the past I gave up on bash checking tools because the few I tested shortly produced tons of...
Only FYI: ``` # find usr/sbin/rear usr/share/rear/ -type f | xargs grep -i 'shellcheck' usr/share/rear/output/USB/Linux-i386/100_create_efiboot.sh:# and https://github.com/koalaman/shellcheck/wiki/SC2155 usr/share/rear/restore/BORG/default/400_restore_backup.sh:# shellcheck disable=SC2168 usr/share/rear/restore/BORG/default/300_load_archives.sh:# shellcheck disable=SC2168 usr/share/rear/restore/BORG/default/300_load_archives.sh:# shellcheck disable=SC2168 usr/share/rear/restore/BORG/default/300_load_archives.sh: # shellcheck disable=SC2034...
That's what I meant: A single pull request caused already noticeable effort for ShellCheck which basically proves my above https://github.com/rear/rear/issues/1040#issuecomment-1034576705 Probably major work is neded to have a general ShellCheck...
Was easier than expected because there is a RPM package ShellCheck for openSUSE Leap 15.3 ``` # for s in usr/sbin/rear $( find usr/share/rear/ -type f -name '*.sh' ) ;...
I expected it! https://github.com/koalaman/shellcheck/wiki/SC2086 is "Double quote to prevent globbing and word splitting" I assume in very most cases we know that quoting is not needed like ``` foo="something" grep...
But the SCnnnn that appear rarely may more likely indicate real errors like the one SC1066 ``` In usr/share/rear/prep/Linux-s390/305_include_s390_tools.sh line 7: test -d "$bootdir" || $bootdir='/boot/' ^-- SC1066: Don't use...
I wrote "no false positives" only to emphasise that the absolute number of false positives is the real problem because human time is the precious thing. Of course in practice...