Johannes Meixner

Regarding "mute defects reported by ShellCheck": In general I am against muting what ShellCheck reports. My reasoning: With muting ShellCheck the issue gets only concealed which makes things worse because...

Regarding unquoted variables: According to https://github.com/rear/rear/issues/1040#issuecomment-1034870262 we had on Feb 10 ``` 3717 SC2086 ``` where SC2086 https://github.com/koalaman/shellcheck/wiki/SC2086 is "Double quote to prevent globbing and word splitting" According to https://github.com/rear/rear/issues/1040#issuecomment-1062945160...

From my experience, cf. https://github.com/rear/rear/issues/1040#issuecomment-1062932894 I think when we globally disable all ShellCheck codes where ShellCheck reports too many false positives, a lot will still be left where things that...

The most often reported ShellCheck codes in our current GitHub master *.sh files: ``` # for s in usr/sbin/rear $( find usr/share/rear/ -type f -name '*.sh' ) ; \ do...

@thomasmerz as far as I see the current main pull request regarding ShellCheck is https://github.com/rear/rear/pull/2847 where @jamacku explained in https://github.com/rear/rear/pull/2847#issuecomment-1350629324 the advantages of his approach so I think your approach...

Let's close this one because things were implemented sufficiently well via https://github.com/rear/rear/pull/2847 and https://github.com/rear/rear/pull/2847 see also https://github.com/rear/rear/issues/1040

Regarding item (b) above see https://github.com/rear/rear/discussions/2948#discussioncomment-5139092 excerpt: ``` Currently there is no guarantee at all that I will find time to implement that item (b). I prefer to keep things...

https://github.com/rear/rear/pull/2961 is a currently work in progress attempt to fix it

With https://github.com/rear/rear/pull/2961 merged this issue should be fixed.

See also https://github.com/rear/rear/pull/2847#issuecomment-1350629324