atom-terminal-tab icon indicating copy to clipboard operation
atom-terminal-tab copied to clipboard

Selection barely visible with light theme

Open w8jcik opened this issue 6 years ago • 2 comments

Theme: One Light / One Light

In order to reproduce just select something in the terminal. Selection doesn't look much different than normal text.

screenshot_2018-02-11_18-27-03

Package versions

  • terminal-tab 0.5.0
  • atom 1.23.3
  • electron 1.7.11
  • electron chrome 58.0.3029.110
  • electron node 7.9.0

(Arch Linux)

w8jcik avatar Feb 11 '18 17:02 w8jcik

I can confirm on Atom 1.27.0-dev-a59bb9671, terminal-tab 0.5.5.

50Wliu avatar Mar 25 '18 17:03 50Wliu

Atom solved this similarly with some crafty use of Less. We may be able to use the same approach to invert the selection color based on background color.

jsmecham avatar Apr 05 '18 13:04 jsmecham