atom-terminal-tab icon indicating copy to clipboard operation
atom-terminal-tab copied to clipboard

Published 20 hours ago • verified publisher icon jsmecham

Uncaught Error: This socket is closed

Open lee-dohm opened this issue 6 years ago • 8 comments

Steps to Reproduce

  1. Launch Atom
  2. Toggle Terminal Tab open
  3. Wait for ready cursor
  4. Type exit

Actual: :boom: Expected: No :boom: and tab to close

Atom: 1.25.0-dev-aea7041c4 x64 Electron: 1.7.10 OS: Mac OS X 10.13.2 Thrown From: terminal-tab package 0.3.4

Stack Trace

Uncaught Error: This socket is closed

At /Users/Lee/.atom/packages/terminal-tab/node_modules/node-pty/lib/unixTerminal.js:108

Error: This socket is closed
    at PipeSocket.Socket._writeGeneric (net.js:692:19)
    at PipeSocket.Socket._write (net.js:743:8)
    at doWrite (_stream_writable.js:329:12)
    at writeOrBuffer (_stream_writable.js:315:5)
    at PipeSocket.Writable.write (_stream_writable.js:241:11)
    at PipeSocket.Socket.write (net.js:670:40)
    at UnixTerminal.write (/packages/terminal-tab/node_modules/node-pty/lib/unixTerminal.js:181:22)
    at /packages/terminal-tab/lib/terminal-view.js:56:23)
    at Terminal.EventEmitter.emit (/packages/terminal-tab/node_modules/xterm/lib/EventEmitter.js:49:20)
    at Terminal.handler (/packages/terminal-tab/node_modules/xterm/lib/xterm.js:1432:10)
    at Terminal.keyDown (/packages/terminal-tab/node_modules/xterm/lib/xterm.js:930:10)
    at /packages/terminal-tab/node_modules/xterm/lib/xterm.js:365:14)

Commands

     -4:42.4.0 core:save (input.hidden-input)
     -4:39.2.0 core:backspace (input.hidden-input)
     -4:37.1.0 core:save (input.hidden-input)
     -4:12 window:toggle-dev-tools (textarea.xterm-helper-textarea)
     -3:54.4.0 settings-view:open (textarea.xterm-helper-textarea)
     -3:07.1.0 window:toggle-dev-tools (textarea.xterm-helper-textarea)
     -1:51.9.0 docblockr:parse-enter (input.hidden-input)
     -1:51.9.0 editor:newline (input.hidden-input)
     -1:51.4.0 docblockr:parse-enter (input.hidden-input)
     -1:51.4.0 editor:newline (input.hidden-input)
     -1:47.4.0 docblockr:parse-enter (input.hidden-input)
     -1:47.4.0 editor:newline (input.hidden-input)
     -1:43.1.0 core:save (input.hidden-input)
  4x -1:05.4.0 core:select-down (input.hidden-input)
     -1:04.5.0 core:backspace (input.hidden-input)
     -1:03.7.0 core:save (input.hidden-input)

Non-Core Packages

advanced-open-file 0.16.7 
atom-2048 3.1.0 
atom-ide-ui 0.7.1 
autocomplete-emojis 2.5.0 
autocomplete-html-entities 0.2.0 
badges 2.2.5 
block-travel 1.0.5 
bug-report 0.7.1 
convert-date 0.1.1 
docblockr 0.13.5 
double-tag 1.1.0 
duotone-dark-syntax 2.1.0 
duotone-light-syntax 2.1.0 
file-icons 2.1.15 
file-type-icons 1.3.4 
fortune-background-tips 1.0.2 
github-atom-light-syntax 0.5.0 
highlight-selected 0.13.1 
ide-css 0.2.0 
ide-rust 0.8.0 
ide-typescript 0.7.2 
indentation-indicator 1.1.0 
language-diff 0.7.0 
language-elixir 0.20.3 
language-generic-config 1.4.0 
language-pegjs 0.5.0 
language-rust 0.4.12 
language-slime 0.0.0 
less-than-slash 0.17.0 
markdown-helper 0.3.0 
minimap 4.29.7 
npm-library-description 1.0.1 
package-sync 1.1.0 
pretty-json 1.6.4 
red-wavy-underline 0.3.3 
right-case 0.2.0 
set-syntax 0.4.0 
significant-other 0.4.0 
soft-wrap-indicator 1.1.0 
sort-lines 0.18.0 
tabs-to-spaces 1.0.3 
teletype 0.5.0 
terminal-tab 0.3.4 
toggle-quotes 1.1.0 
town-crier 0.2.1 
tree-view-git-status 1.4.0

lee-dohm avatar Jan 10 '18 22:01 lee-dohm

Hi @lee-dohm, can you please test again with the 0.5.0 release? I'm not able to reproduce this issue...

jsmecham avatar Feb 11 '18 15:02 jsmecham

Reproduced on the v0.5.0 release:

  1. Launch Atom
  2. Toggle terminal tab open
  3. Wait for ready cursor
  4. Type exit and press Enter
  5. Press Enter again (this is a bug that I see in Hyper too, I assume it's coming from the underlying library you both use?)

Actual: :boom: Expected: No :boom: and tab to close

Atom: 1.25.0-dev-47f17de5f x64 Electron: 1.7.11 OS: Mac OS X 10.13.3 Thrown From: terminal-tab package 0.5.0

Stack Trace

Uncaught Error: This socket is closed

At /Users/Lee/.atom/packages/terminal-tab/node_modules/node-pty-prebuilt/lib/unixTerminal.js:109

Error: This socket is closed
    at PipeSocket.Socket._writeGeneric (net.js:692:19)
    at PipeSocket.Socket._write (net.js:743:8)
    at doWrite (_stream_writable.js:329:12)
    at writeOrBuffer (_stream_writable.js:315:5)
    at PipeSocket.Writable.write (_stream_writable.js:241:11)
    at PipeSocket.Socket.write (net.js:670:40)
    at UnixTerminal.write (/packages/terminal-tab/node_modules/node-pty-prebuilt/lib/unixTerminal.js:182:22)
    at /packages/terminal-tab/lib/terminal-session.js:28:23)
    at Terminal.EventEmitter.emit (/packages/terminal-tab/node_modules/xterm/lib/EventEmitter.js:39:20)
    at Terminal.handler (/packages/terminal-tab/node_modules/xterm/lib/Terminal.js:1370:14)
    at Terminal._keyDown (/packages/terminal-tab/node_modules/xterm/lib/Terminal.js:863:14)
    at /packages/terminal-tab/node_modules/xterm/lib/Terminal.js:325:19)

Commands

     -0:32 command-palette:toggle (input.hidden-input)
     -0:30.5.0 core:confirm (input.hidden-input)
     -0:30.5.0 terminal:open (input.hidden-input)
     -0:06.5.0 core:copy (atom-notification.fatal.icon.icon-bug.native-key-bindings.has-detail.has-close.has-stack)

Non-Core Packages

advanced-open-file 0.16.7 
atom-2048 3.1.0 
atom-ide-ui 0.8.1 
autocomplete-emojis 2.5.0 
autocomplete-html-entities 0.2.0 
badges 2.2.5 
block-travel 1.0.5 
bug-report 0.7.1 
convert-date 0.1.1 
docblockr 0.13.6 
double-tag 1.1.0 
duotone-dark-syntax 2.1.0 
duotone-light-syntax 2.1.0 
file-icons 2.1.16 
file-type-icons 1.3.4 
fortune-background-tips 1.0.2 
github-atom-light-syntax 0.5.0 
highlight-selected 0.13.1 
ide-css 0.2.0 
ide-rust 0.11.2 
ide-typescript 0.7.2 
indentation-indicator 1.1.0 
language-diff 0.7.0 
language-elixir 0.22.0 
language-generic-config 1.4.0 
language-pegjs 0.5.0 
language-rust 0.4.12 
language-slime 0.0.0 
less-than-slash 0.18.0 
markdown-helper 0.3.0 
minimap 4.29.7 
npm-library-description 1.0.1 
package-sync 1.1.0 
pretty-json 1.6.4 
red-wavy-underline 0.3.3 
right-case 0.2.0 
set-syntax 0.4.0 
significant-other 0.4.0 
soft-wrap-indicator 1.1.0 
sort-lines 0.18.0 
tabs-to-spaces 1.0.3 
teletype 0.7.0 
terminal-tab 0.5.0 
toggle-quotes 1.1.0 
town-crier 0.2.1 
tree-view-git-status 1.4.0

lee-dohm avatar Feb 11 '18 19:02 lee-dohm

I also got it when running with only terminal-tab and red-wavy-underline installed (red-wavy-underline is referenced in my stylesheet, so I included it):

Atom: 1.25.0-dev-47f17de5f x64 Electron: 1.7.11 OS: Mac OS X 10.13.3 Thrown From: terminal-tab package 0.5.0

Stack Trace

Uncaught Error: This socket is closed

At /Users/Lee/.atom/packages/terminal-tab/node_modules/node-pty-prebuilt/lib/unixTerminal.js:109

Error: This socket is closed
    at PipeSocket.Socket._writeGeneric (net.js:692:19)
    at PipeSocket.Socket._write (net.js:743:8)
    at doWrite (_stream_writable.js:329:12)
    at writeOrBuffer (_stream_writable.js:315:5)
    at PipeSocket.Writable.write (_stream_writable.js:241:11)
    at PipeSocket.Socket.write (net.js:670:40)
    at UnixTerminal.write (/packages/terminal-tab/node_modules/node-pty-prebuilt/lib/unixTerminal.js:182:22)
    at /packages/terminal-tab/lib/terminal-session.js:28:23)
    at Terminal.EventEmitter.emit (/packages/terminal-tab/node_modules/xterm/lib/EventEmitter.js:39:20)
    at Terminal.handler (/packages/terminal-tab/node_modules/xterm/lib/Terminal.js:1370:14)
    at Terminal._keyDown (/packages/terminal-tab/node_modules/xterm/lib/Terminal.js:863:14)
    at /packages/terminal-tab/node_modules/xterm/lib/Terminal.js:325:19)

Commands

     -0:11.7.0 command-palette:toggle (input.hidden-input)
     -0:09.7.0 core:confirm (input.hidden-input)
     -0:09.7.0 terminal:open (input.hidden-input)

Non-Core Packages

red-wavy-underline 0.3.3 
terminal-tab 0.5.0

lee-dohm avatar Feb 11 '18 19:02 lee-dohm

What shell are you using? I've tried this both with Zsh (my default) and Bash. Other than that, we're both on OS X so we'll need to find other differences so I can replicate this...

jsmecham avatar Feb 12 '18 00:02 jsmecham

I'm using Zsh v5.4.2 installed via Homebrew.

lee-dohm avatar Feb 12 '18 16:02 lee-dohm

I'll try loading it with a clean environment just in case it is something I'm doing in my ~/.zshrc.

lee-dohm avatar Feb 12 '18 16:02 lee-dohm

Still got it with all lines commented out in my ~/.zshrc.

lee-dohm avatar Feb 12 '18 16:02 lee-dohm

MAC OSX HIGH SIERRA I have this issue as well. Occurred after atom 1.25 update. Type exit then press ENTER.

Terminal Tab should close after first ENTER but doesn't. Then when you press ENTER again the error is thrown.

Atom: 1.25.0 x64 Electron: 1.7.11 OS: Mac OS X 10.13.3 Thrown From: terminal-tab package 0.5.4

Stack Trace

Uncaught Error: This socket is closed

At /Users/brycefranzen/.atom/packages/terminal-tab/node_modules/node-pty-prebuilt/lib/unixTerminal.js:109

Error: This socket is closed
    at PipeSocket.Socket._writeGeneric (net.js:692:19)
    at PipeSocket.Socket._write (net.js:743:8)
    at doWrite (_stream_writable.js:329:12)
    at writeOrBuffer (_stream_writable.js:315:5)
    at PipeSocket.Writable.write (_stream_writable.js:241:11)
    at PipeSocket.Socket.write (net.js:670:40)
    at UnixTerminal.write (/packages/terminal-tab/node_modules/node-pty-prebuilt/lib/unixTerminal.js:182:22)
    at /packages/terminal-tab/lib/terminal-session.js:29:23)
    at Terminal.EventEmitter.emit (/packages/terminal-tab/node_modules/xterm/lib/EventEmitter.js:39:20)
    at Terminal.handler (/packages/terminal-tab/node_modules/xterm/lib/Terminal.js:1370:14)
    at Terminal._keyDown (/packages/terminal-tab/node_modules/xterm/lib/Terminal.js:863:14)
    at /packages/terminal-tab/node_modules/xterm/lib/Terminal.js:325:19)

Commands

     -1:16.2.0 command-palette:toggle (input.hidden-input)
     -1:14.6.0 smart-backspace:backspace (input.hidden-input)
     -1:14.6.0 core:backspace (input.hidden-input)
     -1:14.5.0 smart-backspace:backspace (input.hidden-input)
     -1:14.5.0 core:backspace (input.hidden-input)
     -1:14.3.0 smart-backspace:backspace (input.hidden-input)
     -1:14.3.0 core:backspace (input.hidden-input)
     -1:14.2.0 smart-backspace:backspace (input.hidden-input)
     -1:14.2.0 core:backspace (input.hidden-input)
     -1:14 smart-backspace:backspace (input.hidden-input)
     -1:14 core:backspace (input.hidden-input)
  3x -1:12.4.0 core:move-down (input.hidden-input)
     -1:11.8.0 core:confirm (input.hidden-input)
     -1:11.8.0 update-package-dependencies:update (input.hidden-input)
     -0:50.6.0 terminal:open (input.hidden-input)
     -0:05.8.0 notifications-plus:toggle-log (a.notifications-count.inline-block)

Non-Core Packages

aligner 1.2.4 
aligner-css 1.2.1 
aligner-javascript 1.3.0 
aligner-php 1.2.0 
aligner-scss 1.3.1 
atom-beautify 0.32.2 
atom-bootstrap3 1.2.12 
atom-cursor-indent 0.3.0 
atom-ide-ui 0.9.4 
atom-minify 0.8.0 
auto-update-packages 1.0.1 
autoclose-html 0.23.0 
autocomplete-php 0.3.7 
autocomplete-project-paths 2.2.0 
blade-snippets 0.2.0 
blade-spacer 0.4.2 
browser-refresh 0.9.0 
build 0.70.0 
busy-signal 1.4.3 
clipboard-plus 0.5.1 
code-stats-atom 2.0.6 
docblockr 0.13.7 
double-tag 1.1.0 
emmet 2.4.3 
external-open 0.6.3 
file-icons 2.1.17 
filesize 4.0.0 
git-diff-details 1.4.0 
git-history 3.3.0 
git-plus 7.10.2 
gitlab-integration 0.4.6 
ide-css 0.3.0 
ide-docker 0.0.2 
ide-json 0.2.1 
ide-php 0.7.13 
indent-guide-improved 1.4.13 
intentions 1.1.5 
language-blade 0.39.0 
language-docker 1.1.8 
language-dotenv 1.1.1 
language-gitignore 0.3.0 
language-ini 1.19.0 
language-nginx 0.8.0 
language-svg 0.9.2 
laravel 0.7.1 
linter 2.2.0 
linter-bootlint 1.1.0 
linter-csslint 2.0.0 
linter-htmlhint 1.4.0 
linter-php 1.5.1 
linter-scss-lint 3.1.1 
linter-ui-default 1.7.1 
markdown-lists 0.0.2 
minimap 4.29.8 
minimap-git-diff 4.3.1 
minimap-split-diff 0.3.7 
multifile-rename 0.1.6 
next-line-comment 0.2.1 
notifications-plus 0.69.13 
permanent-delete 0.1.7 
persistent-undo 1.3.0 
php-twig 4.0.0 
pigments 0.40.2 
plain-simple 1.1.0 
process-palette 0.16.1 
project-find-filter-defaults 3.0.0 
project-manager 3.3.5 
quick-query 0.12.4 
quick-query-sqlite 0.3.1 
regex-filter-and-generator 1.4.2 
rest-client 1.3.1 
script 3.17.3 
simple-drag-drop-text 0.4.0 
smart-backspace 0.2.3 
split-diff 1.5.2 
status-bar-blame 2.0.2 
sublime-block-comment 0.5.1 
svg-preview 0.12.1 
svgo 3.1.0 
sync-settings 0.8.5 
tabularize 0.2.5 
teletype 0.10.0 
terminal-tab 0.5.4 
text-manipulation 0.6.0 
title-case 0.4.0 
todo-show 2.2.0 
toggle-quotes 1.1.0 
tree-view-auto-collapse 1.0.2 
uglify-html 2.0.0 
undo-tree 1.0.0

brycefranzen avatar Mar 20 '18 20:03 brycefranzen