atom-terminal-tab icon indicating copy to clipboard operation
atom-terminal-tab copied to clipboard

Can't bind keys

Open HebaruSan opened this issue 6 years ago • 3 comments

The default key bindings:

https://github.com/jsmecham/atom-terminal-tab/blob/2796c770791b3c8a150d1d609b5d8180259e991e/keymaps/terminal.json#L5-L9

do not work, and neither does this in the per-user keymap.cson:

'terminal-view':
	'ctrl-tab':       'pane:show-next-item'
	'ctrl-shift-tab': 'pane:show-previous-item'

In all cases, when the key is pressed, nothing happens and the Atom Key Binding Resolver does not even register it. I assume the terminal library is intercepting these, but I haven't been able to figure out how to override it.

HebaruSan avatar Jan 07 '18 21:01 HebaruSan

I cannot make my keymap neither and running the default one conflict with my desktop env. That will be the reason of removing this package from my atom :( that's sad the project is nice btw.

ErwanAliasr1 avatar Jan 16 '18 10:01 ErwanAliasr1

My next focus of work is going to be on key bindings and compatibility. See #66 where I will be tracking this work. Thanks!

jsmecham avatar Feb 12 '18 00:02 jsmecham

I guess what you're doing covers this, but just in case: Some Atom keybindings don't work when the terminal has the keyboard focus. In my case, I'd like to use "F4" to toggle the bottom dock that also contains the terminal. Opening it works, closing it again does not.

I did some digging, as far as I can tell attachCustomKeyEventHandler is the place to modify this behavior.

I would recommend to keep all those keyboard events from the terminal for which atom.keymaps.findKeyBindings returns a binding on the terminal-view element as a target.

allefeld avatar Jan 26 '20 21:01 allefeld