atom-terminal-tab icon indicating copy to clipboard operation
atom-terminal-tab copied to clipboard

Published 20 hours ago • verified publisher icon jsmecham

Customize TERM variable option

Open BDMorrell opened this issue 4 years ago • 2 comments

Can we have a way to declare which terminal we're using?

Most of my terminal colors don't work with the default xterm-color, and it seems that xterm-256color is supported by this addon:

this seems like a hack to me

I'm using

  • zsh "z shell" (technically with the "oh my zsh" addon, and themed with p10k)
  • macOS 10.15.3

Thank you! Great addon, by the way!

BDMorrell avatar Mar 17 '20 19:03 BDMorrell

Curious if there's any harm in just defaulting to xterm-256color? I'd like to avoid adding options and settings, if possible, as my goal for this addon is to work out of the box for most people without thinking about configuration.

jsmecham avatar Mar 19 '20 13:03 jsmecham

Doing some research, it seems that TERM=xterm-256color should be okay. I haven't found anything that would say otherwise.

While we're at it, why not set COLORTERM=truecolor? I would say it's supported because of xtermjs/xterm.js#1895.

I also found an article about terminal colors.

I don't quite know how to set these variables accurately, but it seems that it would have to do with lib/terminal-session: https://github.com/jsmecham/atom-terminal-tab/blob/d608f7166586a9d8bffe98007b37118e8040e27b/lib/terminal-session.js#L45-L49

BDMorrell avatar Apr 01 '20 18:04 BDMorrell