compare-plugin icon indicating copy to clipboard operation
compare-plugin copied to clipboard

[Enhancement] A new extra Status Bar for Compare

Open jsleroy opened this issue 8 years ago • 6 comments

Issue by Yaron10 Friday Mar 18, 2016 at 02:30 GMT Originally opened as https://github.com/pnedev/compare-plugin/issues/16


A new extra Status Bar for Compare could be useful.

It should have the following segments:

  1. Total diffs.

  2. No. of added lines.

  3. No. of removed lines.

  4. No. of not equal lines.

  5. No. of moved lines.

  6. Various messages: "No files to compare.", "Can not locate Git." etc.

  7. A small Progress Bar. Pressing "Clear Results" should terminate the process and close the status bar.


Originally opened in: https://github.com/jsleroy/compare-plugin/issues/9

jsleroy avatar Jul 23 '16 07:07 jsleroy

Comment by pnedev Friday Mar 18, 2016 at 07:55 GMT


Hello Yaron,

I didn't quite get point 7 - You mean to remove the Cancel button from the progress and to be able to cancel from Clear Results? Please explain a bit.

BR

jsleroy avatar Jul 23 '16 07:07 jsleroy

Comment by Yaron10 Friday Mar 18, 2016 at 15:04 GMT


Hello Pavel,

If you implement a Status Bar, wouldn't it be better to have the Progress Bar as one of its segment? (Like the progress bar in some browsers indicating page load). If so, you wouldn't have a Cancel button but rather use the "Stop/Clear Results" button to terminate the process.

Best regards.

jsleroy avatar Jul 23 '16 07:07 jsleroy

Comment by pnedev Saturday Mar 19, 2016 at 15:17 GMT


Hi Yaron,

Hm, I imagined this a bit different. You would have a normal compare (as it is now) and after the compare finishes a window with compare summary would appear. How does it sound to you?

BR, Pavel

jsleroy avatar Jul 23 '16 07:07 jsleroy

Comment by Yaron10 Sunday Mar 20, 2016 at 01:39 GMT


Hello Pavel,

and after the compare finishes a window with compare summary would appear.

And you'd have to press OK, correct? Since you've already got a proper Progress Bar, let's refer only to the other segments. Wouldn't a bar at the bottom of the window be much better? - Your workflow wouldn't be interrupted, and you could go on checking the diffs and see the extra info as well.

If not a proper toolbar, how about something similar to the Incremental Find Bar? (I've slightly modified it and it can look much nicer).

I have no clue as to the amount of work it might require; so it's easier written than done. :)

Thank you.

Best regards.

jsleroy avatar Jul 23 '16 07:07 jsleroy

Comment by pnedev Sunday Mar 20, 2016 at 16:37 GMT


Hello Yaron,

I'll think about it later. I'd like to focus on the stability issues first.

BR, Pavel

jsleroy avatar Jul 23 '16 07:07 jsleroy

Comment by Yaron10 Sunday Mar 20, 2016 at 17:13 GMT


Hello Pavel,

Great. Thank you so much.

BR.

jsleroy avatar Jul 23 '16 07:07 jsleroy