John Sirois
John Sirois
If you all would be interested to moving to PEX packaging instead of or in addition to your current `.pyz` packaging; I'd be happy to work on a PR to...
Ah, yes Windows (and Python 3.4). I'll take a crack at a PR to fixup the existing zipapp main module as you suggest. I do want to note that Pex...
Hrm, so the sys.path ordering is just fine. the virtualenv.pyz is in the 1st slot and virtualenv imports from there. That's, of course, what leads to the subsequent error when...
Is that legit? I'll try that if its ok. I assumed your plugin mechanism was meant to allow plugins on the sys.path and this would defeat that IIUC.
Ok. Sounds good to me. I'll pick this back up with that in mind.
Ok, I started re-reviewing this from the top instead of focusing in on Pex. That leads here: https://github.com/pantsbuild/pants/blob/0bbf1fbb6078cacb1e3a75f5ea67a14d0398910c/src/python/pants/backend/python/util_rules/pex.py#L750-L757 Clearly? the rm -rf can be interrupted and since `rm -r` is...
I think if the above is the explanation, then just switching to Pex's `--sh-boot` mode and eliminating the wrapper script will do the trick and allow Pants to keep all...
Alrighty, thanks for the confirmation. I think the issue is now fully understood. I want to stew a bit more on the `--sh-boot` fix vs just removing the `rm -rf`...
Ok, the `rm -rf` was in there from the get-go a year and 1/2 ago: https://github.com/pantsbuild/pants/pull/11557/files#r575485648 I seem to recall during development of that PR that I initially didn't have...
Ok, the `--sh-boot` will still require scripts or some new `--sh-boot` `PEX_SCRIPT` affordance or some sort of [conscript](https://pypi.org/project/conscript/)-like system since code like this needs to point directly at various console...